summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTor Brede Vekterli <vekterli@verizonmedia.com>2020-05-05 16:56:22 +0200
committerGitHub <noreply@github.com>2020-05-05 16:56:22 +0200
commit6c0eab34d73d98bab35eb727bb792cb4783ba25a (patch)
treed5b5d3a0a97f7d4430c6e187148ae4292ce7f984
parent02a7dbc6c9dfd39c96eb9d72df92f43592ada2bf (diff)
parent3520e4d740d158f7ed08e695abcfff3ae807d436 (diff)
Merge pull request #13157 from vespa-engine/vekterli/downgrade-log-level-on-node-watch-state-race
Downgrade log level when node watch races with internal state resets
-rw-r--r--clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/MasterDataGatherer.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/MasterDataGatherer.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/MasterDataGatherer.java
index cd5202c89b2..fef93aede1a 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/MasterDataGatherer.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/MasterDataGatherer.java
@@ -121,7 +121,10 @@ public class MasterDataGatherer {
if (nextMasterData.containsKey(index)) {
nextMasterData.remove(index);
} else {
- log.log(Level.SEVERE, "Fleetcontroller " + nodeIndex + ": Strangely, we already had data from node " + index + " when trying to remove it");
+ // May happen when pending data watch error callbacks are triggered concurrently with
+ // internal voting state having already been cleared due to connectivity issues.
+ log.log(Level.INFO, String.format("Fleetcontroller %d: ignoring removal of vote from node %d " +
+ "since it was not present in existing vote mapping", nodeIndex, index));
}
} else {
Integer value = Integer.valueOf(data);