summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHåkon Hallingstad <hakon@verizonmedia.com>2020-05-03 22:06:10 +0200
committerHåkon Hallingstad <hakon@verizonmedia.com>2020-05-03 22:06:10 +0200
commitb75fc4be1d5c8a38d75740e33c681490762f102d (patch)
tree9645345bfdaf0392c24360a1a99dd31a691525b4
parent2de4490282f123989a2ee8fbb7e5c92968d876c1 (diff)
Use /home/docker/container-storage as default container storage path
-rw-r--r--node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImpl.java2
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java6
-rw-r--r--node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImplTest.java8
3 files changed, 8 insertions, 8 deletions
diff --git a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImpl.java b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImpl.java
index b12a6b93801..90814924de5 100644
--- a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImpl.java
+++ b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImpl.java
@@ -303,7 +303,7 @@ public class NodeAgentContextImpl implements NodeAgentContext {
}
}),
fileSystem,
- fileSystem.getPath("/home/docker"),
+ fileSystem.getPath("/home/docker/container-storage"),
fileSystem.getPath("/opt/vespa"),
Optional.ofNullable(vespaUser).orElse("vespa"),
Optional.ofNullable(vespaUserOnHost).orElse("container_vespa"),
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java
index 3a3d087e644..cb615a94615 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/maintenance/StorageMaintainerTest.java
@@ -52,7 +52,7 @@ public class StorageMaintainerTest {
NodeAgentContext context = new NodeAgentContextImpl.Builder("host-1.domain.tld").fileSystem(fileSystem).build();
Files.createDirectories(context.pathOnHostFromPathInNode("/"));
- terminal.expectCommand("du -xsk /home/docker/host-1 2>&1", 0, "321\t/home/docker/host-1/");
+ terminal.expectCommand("du -xsk /home/docker/container-storage/host-1 2>&1", 0, "321\t/home/docker/container-storage/host-1/");
assertEquals(Optional.of(DiskSize.of(328_704)), storageMaintainer.diskUsageFor(context));
// Value should still be cached, no new execution against the terminal
@@ -80,7 +80,7 @@ public class StorageMaintainerTest {
NodeAgentContext context1 = createNodeAgentContextAndContainerStorage(fileSystem, "container-1");
createNodeAgentContextAndContainerStorage(fileSystem, "container-2");
- Path pathToArchiveDir = fileSystem.getPath("/home/docker/container-archive");
+ Path pathToArchiveDir = fileSystem.getPath("/home/docker/container-storage/container-archive");
Files.createDirectories(pathToArchiveDir);
Path containerStorageRoot = context1.pathOnHostFromPathInNode("/").getParent();
@@ -181,7 +181,7 @@ public class StorageMaintainerTest {
}
private void mockDiskUsage(long kBytes) {
- terminal.expectCommand("du -xsk /home/docker/h123a 2>&1", 0, kBytes + "\t/path");
+ terminal.expectCommand("du -xsk /home/docker/container-storage/h123a 2>&1", 0, kBytes + "\t/path");
}
}
}
diff --git a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImplTest.java b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImplTest.java
index d8e97ee47b7..9bcbce849af 100644
--- a/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImplTest.java
+++ b/node-admin/src/test/java/com/yahoo/vespa/hosted/node/admin/nodeagent/NodeAgentContextImplTest.java
@@ -22,11 +22,11 @@ public class NodeAgentContextImplTest {
@Test
public void path_on_host_from_path_in_node_test() {
assertEquals(
- "/home/docker/container-1",
+ "/home/docker/container-storage/container-1",
context.pathOnHostFromPathInNode("/").toString());
assertEquals(
- "/home/docker/container-1/dev/null",
+ "/home/docker/container-storage/container-1/dev/null",
context.pathOnHostFromPathInNode("/dev/null").toString());
}
@@ -39,7 +39,7 @@ public class NodeAgentContextImplTest {
public void path_in_node_from_path_on_host_test() {
assertEquals(
"/dev/null",
- context.pathInNodeFromPathOnHost(fileSystem.getPath("/home/docker/container-1/dev/null")).toString());
+ context.pathInNodeFromPathOnHost(fileSystem.getPath("/home/docker/container-storage/container-1/dev/null")).toString());
}
@Test(expected=IllegalArgumentException.class)
@@ -49,7 +49,7 @@ public class NodeAgentContextImplTest {
@Test(expected=IllegalArgumentException.class)
public void path_on_host_must_be_inside_container_storage_of_context() {
- context.pathInNodeFromPathOnHost(fileSystem.getPath("/home/docker/container-2/dev/null"));
+ context.pathInNodeFromPathOnHost(fileSystem.getPath("/home/docker/container-storage/container-2/dev/null"));
}
@Test(expected=IllegalArgumentException.class)