summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Bratseth <jonbratseth@yahoo.com>2018-01-23 16:07:23 +0100
committerGitHub <noreply@github.com>2018-01-23 16:07:23 +0100
commit344e2c8d583b13a365f5c17ca9fc467e5d7d357d (patch)
treea1d518f09bc066556635577595a60c6ed8f24346
parentabc111e455e8533e630b4e3ddaf13e1f8e3c0d65 (diff)
parentd1b1b6633d258cce0af7a56068713dd86dbe2452 (diff)
Merge pull request #4757 from vespa-engine/bratseth/handle-no-file
Handle missing files properly
-rw-r--r--config-model/src/main/java/com/yahoo/searchdefinition/expressiontransforms/TensorFlowFeatureConverter.java2
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/zookeeper/ZKApplicationPackage.java2
2 files changed, 3 insertions, 1 deletions
diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/expressiontransforms/TensorFlowFeatureConverter.java b/config-model/src/main/java/com/yahoo/searchdefinition/expressiontransforms/TensorFlowFeatureConverter.java
index c16d12f76d1..c95601f6bbf 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/expressiontransforms/TensorFlowFeatureConverter.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/expressiontransforms/TensorFlowFeatureConverter.java
@@ -187,7 +187,7 @@ public class TensorFlowFeatureConverter extends ExpressionTransformer<RankProfil
public boolean hasTensorFlowModels() {
try {
- return application.getFileReference(ApplicationPackage.MODELS_DIR).exists();
+ return application.getFile(ApplicationPackage.MODELS_DIR).exists();
}
catch (UnsupportedOperationException e) {
return false; // No files -> no TensorFlow models
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/zookeeper/ZKApplicationPackage.java b/configserver/src/main/java/com/yahoo/vespa/config/server/zookeeper/ZKApplicationPackage.java
index 6643e9b3370..2c46f591037 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/zookeeper/ZKApplicationPackage.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/zookeeper/ZKApplicationPackage.java
@@ -261,6 +261,8 @@ public class ZKApplicationPackage implements ApplicationPackage {
@Override
public File getFileReference(Path pathRelativeToAppDir) {
String fileName = liveApp.getData(ConfigCurator.USERAPP_ZK_SUBPATH + "/" + pathRelativeToAppDir.getRelative());
+ if (fileName == null)
+ return new File(pathRelativeToAppDir.getRelative()); // File does not exist: Manufacture a non-existing file
return new File(fileName);
}