summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-12-01 12:07:27 +0100
committerGitHub <noreply@github.com>2020-12-01 12:07:27 +0100
commitc63b36b1e661da04889abaccd01fd2a6c4ed783f (patch)
treebec752a2f52d97f023d0c07e1edb69e1cebce7bc
parent26c16eeb3d4d792938ab9af9aff1e01b540a6f42 (diff)
parentad6ba3b37c5adfe6ba461b0815169825cc0a9d81 (diff)
Merge pull request #15557 from vespa-engine/arnej/avoid-fsync-10-times-per-second
avoid calling nativeIO.dropPartialFileFromCache too often
-rw-r--r--container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java b/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java
index a3d34ae6a2c..ab246a21a43 100644
--- a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java
+++ b/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java
@@ -125,8 +125,10 @@ public class LogFileHandler extends StreamHandler {
try {
if (currentOutputStream != null) {
long newPos = currentOutputStream.getChannel().position();
- nativeIO.dropPartialFileFromCache(currentOutputStream.getFD(), lastDropPosition, newPos, true);
- lastDropPosition = newPos;
+ if (newPos > lastDropPosition + 102400) {
+ nativeIO.dropPartialFileFromCache(currentOutputStream.getFD(), lastDropPosition, newPos, true);
+ lastDropPosition = newPos;
+ }
}
} catch (IOException e) {
logger.warning("Failed dropping from cache : " + Exceptions.toMessageString(e));