diff options
author | Harald Musum <musum@verizonmedia.com> | 2020-06-24 11:30:04 +0200 |
---|---|---|
committer | Harald Musum <musum@verizonmedia.com> | 2020-06-24 11:30:04 +0200 |
commit | 31d0b71c86f594cfc6776d396c5944c36fdc4e91 (patch) | |
tree | 8271f4a9b49ee06e1d34a368cde8f57c22b2ffff | |
parent | 8b347ed7f98088f902430738152d90396a7d190e (diff) |
Get curator from TenantRepository
Will try to remove the need to inject Curator instance in Tenant
constructor
4 files changed, 8 insertions, 8 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java index becf01c191c..3eb00a0adef 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/ApplicationRepository.java @@ -59,6 +59,7 @@ import com.yahoo.vespa.config.server.tenant.ContainerEndpointsCache; import com.yahoo.vespa.config.server.tenant.EndpointCertificateMetadataStore; import com.yahoo.vespa.config.server.tenant.Tenant; import com.yahoo.vespa.config.server.tenant.TenantRepository; +import com.yahoo.vespa.curator.Curator; import com.yahoo.vespa.curator.Lock; import com.yahoo.vespa.orchestrator.Orchestrator; @@ -389,11 +390,12 @@ public class ApplicationRepository implements com.yahoo.config.provision.Deploye } NestedTransaction transaction = new NestedTransaction(); - transaction.add(new ContainerEndpointsCache(tenant.getPath(), tenant.getCurator()).delete(applicationId)); // TODO: Not unit tested + Curator curator = tenantRepository.getCurator(); + transaction.add(new ContainerEndpointsCache(tenant.getPath(), curator).delete(applicationId)); // TODO: Not unit tested // Delete any application roles - transaction.add(new ApplicationRolesStore(tenant.getCurator(), tenant.getPath()).delete(applicationId)); + transaction.add(new ApplicationRolesStore(curator, tenant.getPath()).delete(applicationId)); // Delete endpoint certificates - transaction.add(new EndpointCertificateMetadataStore(tenant.getCurator(), tenant.getPath()).delete(applicationId)); + transaction.add(new EndpointCertificateMetadataStore(curator, tenant.getPath()).delete(applicationId)); // (When rotations are updated in zk, we need to redeploy the zone app, on the right config server // this is done asynchronously in application maintenance by the node repository) transaction.add(tenantApplications.createDeleteTransaction(applicationId)); diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/Tenant.java b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/Tenant.java index bf0601bf2f1..61ee31ee203 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/Tenant.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/Tenant.java @@ -72,10 +72,6 @@ public class Tenant implements TenantHandlerProvider { return applicationRepo; } - public Curator getCurator() { - return curator; - } - public Instant getCreatedTime() { Optional<Stat> stat = curator.getStat(path); if (stat.isPresent()) diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java index 03849e64595..2ca9bf795ef 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java @@ -441,4 +441,6 @@ public class TenantRepository { return locksPath.append(tenantName.value()); } + public Curator getCurator() { return curator; } + } diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java index 9781d12991a..c6d2c6b6438 100644 --- a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java +++ b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java @@ -431,7 +431,7 @@ public class ApplicationRepositoryTest { var prepareParams = new PrepareParams.Builder().applicationId(applicationId) .applicationRoles(ApplicationRoles.fromString("hostRole","containerRole")).build(); deployApp(testApp, prepareParams); - var approlesStore = new ApplicationRolesStore(tenant.getCurator(), tenant.getPath()); + var approlesStore = new ApplicationRolesStore(tenantRepository.getCurator(), tenant.getPath()); var appRoles = approlesStore.readApplicationRoles(applicationId); // App roles present after deploy |