summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLester Solbakken <lesters@oath.com>2020-06-22 11:25:02 +0200
committerLester Solbakken <lesters@oath.com>2020-06-22 11:25:02 +0200
commit65b517d259fe417ce0cdb417336ef839e396a820 (patch)
treea7cd3de7a0c117e5f88bb8fd1dc55ee8d6a280b2
parent3a66636ae7790b334467898ab31badf522f70a1e (diff)
Don't add function names multiple times
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java b/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java
index f8b48da291d..e618326eff5 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java
@@ -553,9 +553,10 @@ public class ConvertedModel {
if (node instanceof ReferenceNode) {
ReferenceNode referenceNode = (ReferenceNode)node;
if (referenceNode.getOutput() == null) { // function references cannot specify outputs
- names.add(referenceNode.getName());
- if (model.functions().containsKey(referenceNode.getName())) {
- addFunctionNamesIn(RankingExpression.from(model.functions().get(referenceNode.getName())).getRoot(), names, model);
+ if (names.add(referenceNode.getName())) {
+ if (model.functions().containsKey(referenceNode.getName())) {
+ addFunctionNamesIn(RankingExpression.from(model.functions().get(referenceNode.getName())).getRoot(), names, model);
+ }
}
}
}