Merge pull request #13654 from vespa-engine/lesters/dont-add-function-names-multiple-times

Don't add function names multiple times

1 files changed, 4 insertions, 3 deletions

diff --git a/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java b/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java
index f8b48da291d..e618326eff5 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/ml/ConvertedModel.java
@@ -553,9 +553,10 @@ public class ConvertedModel {
         if (node instanceof ReferenceNode) {
             ReferenceNode referenceNode = (ReferenceNode)node;
             if (referenceNode.getOutput() == null) { // function references cannot specify outputs
-                names.add(referenceNode.getName());
-                if (model.functions().containsKey(referenceNode.getName())) {
-                    addFunctionNamesIn(RankingExpression.from(model.functions().get(referenceNode.getName())).getRoot(), names, model);
+                if (names.add(referenceNode.getName())) {
+                    if (model.functions().containsKey(referenceNode.getName())) {
+                        addFunctionNamesIn(RankingExpression.from(model.functions().get(referenceNode.getName())).getRoot(), names, model);
+                    }
                 }
             }
         }