summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2020-06-30 13:56:37 +0200
committerJon Bratseth <bratseth@gmail.com>2020-06-30 13:56:37 +0200
commit2b5907b1df400a4f7af2dc3e29b4035fd6ce3f49 (patch)
tree61b8da132de74df30a3d488e273f8c696bfce2b2
parentedae1471bca822503c3d7f1d796929dc5678e0a9 (diff)
Remove unused internal methods
-rw-r--r--container-search/abi-spec.json8
-rw-r--r--container-search/src/main/java/com/yahoo/search/query/profile/QueryProfileCompiler.java5
-rw-r--r--container-search/src/test/java/com/yahoo/search/query/profile/config/test/XmlReadingTestCase.java12
3 files changed, 20 insertions, 5 deletions
diff --git a/container-search/abi-spec.json b/container-search/abi-spec.json
index ba52826cd3f..6a191248e13 100644
--- a/container-search/abi-spec.json
+++ b/container-search/abi-spec.json
@@ -5732,7 +5732,6 @@
"public final java.util.Map listValues(java.lang.String, java.util.Map)",
"public final java.util.Map listValues(com.yahoo.processing.request.CompoundName, java.util.Map)",
"public java.util.Map listValues(com.yahoo.processing.request.CompoundName, java.util.Map, com.yahoo.processing.request.Properties)",
- "public java.util.Map listTypes(com.yahoo.processing.request.CompoundName, java.util.Map)",
"public final java.lang.Object get(java.lang.String)",
"public final java.lang.Object get(java.lang.String, java.util.Map)",
"public final java.lang.Object get(java.lang.String, java.lang.String[])",
@@ -6064,8 +6063,8 @@
"public"
],
"methods": [
- "public void <init>()",
"public void <init>(com.yahoo.search.query.profile.config.QueryProfilesConfig)",
+ "public void <init>()",
"public void <init>(com.yahoo.search.query.profile.types.QueryProfileTypeRegistry)",
"public final void register(com.yahoo.search.query.profile.compiled.CompiledQueryProfile)",
"public com.yahoo.search.query.profile.types.QueryProfileTypeRegistry getTypeRegistry()",
@@ -6137,9 +6136,12 @@
"public"
],
"methods": [
- "public void <init>(java.lang.Object, java.lang.String, com.yahoo.search.query.profile.DimensionValues)",
+ "public void <init>(java.lang.Object, java.lang.String, boolean, boolean, com.yahoo.search.query.profile.types.QueryProfileType, com.yahoo.search.query.profile.DimensionValues)",
"public java.lang.Object value()",
"public java.lang.String source()",
+ "public boolean isUnoverridable()",
+ "public boolean isQueryProfile()",
+ "public com.yahoo.search.query.profile.types.QueryProfileType queryProfileType()",
"public com.yahoo.search.query.profile.compiled.ValueWithSource withValue(java.lang.Object)",
"public java.util.Optional variant()",
"public java.lang.String toString()"
diff --git a/container-search/src/main/java/com/yahoo/search/query/profile/QueryProfileCompiler.java b/container-search/src/main/java/com/yahoo/search/query/profile/QueryProfileCompiler.java
index 98dbdf61f0b..68199777cb7 100644
--- a/container-search/src/main/java/com/yahoo/search/query/profile/QueryProfileCompiler.java
+++ b/container-search/src/main/java/com/yahoo/search/query/profile/QueryProfileCompiler.java
@@ -41,11 +41,12 @@ public class QueryProfileCompiler {
Set<DimensionBindingForPath> variants = collectVariants(CompoundName.empty, in, DimensionBinding.nullBinding);
variants.add(new DimensionBindingForPath(DimensionBinding.nullBinding, CompoundName.empty)); // if this contains no variants
log.fine(() -> "Compiling " + in.toString() + " having " + variants.size() + " variants");
- // System.out.println("Compiling " + in.toString() + " having " + variants.size() + " variants");
+ System.out.println("Compiling " + in.toString() + " having " + variants.size() + " variants");
for (DimensionBindingForPath variant : variants) {
log.finer(() -> " Compiling variant " + variant);
- // System.out.println(" Compiling variant " + variant);
+ System.out.println(" Compiling variant " + variant);
for (Map.Entry<String, ValueWithSource> entry : in.visitValues(variant.path(), variant.binding().getContext()).valuesWithSource().entrySet()) {
+ System.out.println(" got " + entry);
CompoundName fullName = variant.path().append(entry.getKey());
values.put(fullName, variant.binding(), entry.getValue());
if (entry.getValue().isUnoverridable())
diff --git a/container-search/src/test/java/com/yahoo/search/query/profile/config/test/XmlReadingTestCase.java b/container-search/src/test/java/com/yahoo/search/query/profile/config/test/XmlReadingTestCase.java
index 154a4dd4fee..20e1370d29d 100644
--- a/container-search/src/test/java/com/yahoo/search/query/profile/config/test/XmlReadingTestCase.java
+++ b/container-search/src/test/java/com/yahoo/search/query/profile/config/test/XmlReadingTestCase.java
@@ -32,6 +32,18 @@ import static org.junit.Assert.fail;
*/
public class XmlReadingTestCase {
+ @Ignore
+ @Test
+ public void testTmp() {
+ QueryProfileRegistry registry =
+ new QueryProfileXMLReader().read("/Users/bratseth/development/slingstone/massmedia_serving/homerun/src/main/application/search/flattened");
+
+ long startTime = System.currentTimeMillis();
+ System.out.println("Compiling ...");
+ CompiledQueryProfileRegistry cRegistry = registry.compile();
+ System.out.println("Done in " + ((System.currentTimeMillis() - startTime) / 1000) + " seconds");
+ }
+
@Test
public void testValid() {
QueryProfileRegistry registry=