summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTor Brede Vekterli <vekterli@yahooinc.com>2022-01-28 13:15:02 +0100
committerGitHub <noreply@github.com>2022-01-28 13:15:02 +0100
commitc58fe9e096554ec64a64060db4fc127f9d89f614 (patch)
tree32834c183ca40c6a535683acf0ff7629cb0e97f4
parentcd8989a3b937668495ffea36c3ba3a3a285803c0 (diff)
parentecfc1d6830891cbbd39c71cf9f64d2ecd8b03c7f (diff)
Merge pull request #20975 from vespa-engine/vekterli/avoid-core-on-aborted-node-startup
Avoid assertion failure on aborted node startup
-rw-r--r--storage/src/vespa/storage/persistence/filestorage/modifiedbucketchecker.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/storage/src/vespa/storage/persistence/filestorage/modifiedbucketchecker.cpp b/storage/src/vespa/storage/persistence/filestorage/modifiedbucketchecker.cpp
index 3ad34a94726..90f7f292a6d 100644
--- a/storage/src/vespa/storage/persistence/filestorage/modifiedbucketchecker.cpp
+++ b/storage/src/vespa/storage/persistence/filestorage/modifiedbucketchecker.cpp
@@ -97,7 +97,9 @@ ModifiedBucketChecker::onClose()
if (_singleThreadMode) {
return;
}
- assert(_thread);
+ if (!_thread) {
+ return; // Aborted startup; onOpen() was never called so there's nothing to close.
+ }
LOG(debug, "Interrupting modified bucket checker thread");
_thread->interrupt();
_cond.notify_one();