summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2020-09-11 09:33:12 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2020-09-11 09:33:12 +0000
commit37d72a0d89a00ffc9a92a65d38cb78fd404e746f (patch)
treed29f5cbd57525d07e7e9ea83609f8edcccb06060
parent0074fd7b101a9415fa6f6c5311f307cd311508f1 (diff)
Test move assignment instead.
-rw-r--r--document/src/tests/fieldvalue/predicatefieldvalue_test.cpp13
1 files changed, 5 insertions, 8 deletions
diff --git a/document/src/tests/fieldvalue/predicatefieldvalue_test.cpp b/document/src/tests/fieldvalue/predicatefieldvalue_test.cpp
index 41df9f9967b..1a9f0993b9b 100644
--- a/document/src/tests/fieldvalue/predicatefieldvalue_test.cpp
+++ b/document/src/tests/fieldvalue/predicatefieldvalue_test.cpp
@@ -1,19 +1,16 @@
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
// Unit tests for predicatefieldvalue.
-#include <vespa/log/log.h>
-LOG_SETUP("predicatefieldvalue_test");
-
-#include <vespa/document/predicate/predicate.h>
-#include <vespa/vespalib/data/slime/slime.h>
#include <vespa/vespalib/testkit/testapp.h>
#include <vespa/document/datatype/datatype.h>
#include <vespa/document/fieldvalue/predicatefieldvalue.h>
#include <vespa/document/predicate/predicate_slime_builder.h>
-#include <sstream>
#include <string>
+#include <vespa/log/log.h>
+LOG_SETUP("predicatefieldvalue_test");
+
using std::ostringstream;
using std::string;
using vespalib::Slime;
@@ -29,7 +26,7 @@ void verifyEqual(const FieldValue & a, const FieldValue & b) {
ASSERT_EQUAL(o1.str(), o2.str());
}
-TEST("require that PredicateFieldValue can be cloned, assigned, and operator=") {
+TEST("require that PredicateFieldValue can be cloned, assigned") {
PredicateSlimeBuilder builder;
builder.neg().feature("foo").value("bar").value("baz");
PredicateFieldValue val(builder.build());
@@ -42,7 +39,7 @@ TEST("require that PredicateFieldValue can be cloned, assigned, and operator=")
verifyEqual(val, assigned);
PredicateFieldValue operatorAssigned;
- operatorAssigned = val;
+ operatorAssigned = std::move(assigned);
verifyEqual(val, operatorAssigned);
}