summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2021-01-25 15:30:16 +0100
committerGitHub <noreply@github.com>2021-01-25 15:30:16 +0100
commit7280724b0eef1ffaf899b3ae67fdc9310c0871b4 (patch)
tree9176e31e1c8e2dba973a82b6e1c84bf7cfa8b2ca
parent825b275d06f9f00033bce8fb27b7622c59fcd9a6 (diff)
parent92e0fd4a70cf983b84d84b49f55c124caec265d3 (diff)
Merge pull request #16204 from vespa-engine/balder/sync-executor-on-shutdown
Sync executor when destructing the jobs.
-rw-r--r--searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_jobtest.cpp1
-rw-r--r--searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job_take2.cpp4
2 files changed, 4 insertions, 1 deletions
diff --git a/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_jobtest.cpp b/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_jobtest.cpp
index af8086941fd..ef53a78182c 100644
--- a/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_jobtest.cpp
+++ b/searchcore/src/tests/proton/documentdb/lid_space_compaction/lid_space_jobtest.cpp
@@ -49,6 +49,7 @@ JobTestBase::init(uint32_t allowedLidBloat,
REMOVE_BATCH_BLOCK_RATE, REMOVE_BLOCK_RATE, false, useBucketDB());
BlockableMaintenanceJobConfig blockableCfg(resourceLimitFactor, maxOutstandingMoveOps);
+ _job.reset();
if (useBucketDB()) {
_singleExecutor = std::make_unique<vespalib::ThreadStackExecutor>(1, 0x10000);
_master = std::make_unique<proton::ExecutorThreadService> (*_singleExecutor);
diff --git a/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job_take2.cpp b/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job_take2.cpp
index 73645844239..634662f7e2d 100644
--- a/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job_take2.cpp
+++ b/searchcore/src/vespa/searchcore/proton/server/lid_space_compaction_job_take2.cpp
@@ -77,6 +77,8 @@ CompactionJob::CompactionJob(const DocumentDBLidSpaceCompactionConfig &config,
{
}
-CompactionJob::~CompactionJob() = default;
+CompactionJob::~CompactionJob() {
+ _bucketExecutor.sync();
+}
} // namespace proton