diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-04-29 16:00:38 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-29 16:00:38 +0200 |
commit | 3d8b8d9be7140980f66bbc8e105d972d403bfcd9 (patch) | |
tree | 2d34c8c0df0853f9a3a90222b608d677531fc83c | |
parent | d1945f85161b2436bd18f685e3517c35640c30af (diff) | |
parent | 46e7689040c0986654e6bd495b726f010aa71bc1 (diff) |
Merge pull request #22367 from vespa-engine/hmusum/lower-log-level-when-failing-to-acquire-application-lock
Use log level INFO for exceptions getting application lock
2 files changed, 6 insertions, 2 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/MaintenanceDeployment.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/MaintenanceDeployment.java index 511d3efe313..b2c3859e33a 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/MaintenanceDeployment.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/MaintenanceDeployment.java @@ -110,7 +110,7 @@ class MaintenanceDeployment implements Closeable { return Optional.of(nodeRepository.nodes().lock(application, timeout)); } catch (ApplicationLockException e) { - log.log(Level.WARNING, () -> "Could not lock " + application + " for maintenance deployment within " + timeout); + log.log(Level.INFO, () -> "Could not lock " + application + " for maintenance deployment within " + timeout); return Optional.empty(); } } diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiHandler.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiHandler.java index f05492162db..c5d8b2518e5 100644 --- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiHandler.java +++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/restapi/NodesV2ApiHandler.java @@ -3,6 +3,7 @@ package com.yahoo.vespa.hosted.provision.restapi; import com.yahoo.component.Version; import com.yahoo.config.provision.ApplicationId; +import com.yahoo.config.provision.ApplicationLockException; import com.yahoo.config.provision.Flavor; import com.yahoo.config.provision.HostFilter; import com.yahoo.config.provision.NodeFlavors; @@ -43,7 +44,6 @@ import com.yahoo.vespa.hosted.provision.node.filter.ParentHostFilter; import com.yahoo.vespa.hosted.provision.restapi.NodesResponse.ResponseType; import com.yahoo.vespa.orchestrator.Orchestrator; import com.yahoo.yolean.Exceptions; - import javax.inject.Inject; import java.io.IOException; import java.io.UncheckedIOException; @@ -102,6 +102,10 @@ public class NodesV2ApiHandler extends ThreadedHttpRequestHandler { catch (IllegalArgumentException e) { return ErrorResponse.badRequest(Exceptions.toMessageString(e)); } + catch (ApplicationLockException e) { + log.log(Level.INFO, "Timed out getting lock when handling '" + request.getUri() + "': " + Exceptions.toMessageString(e)); + return ErrorResponse.internalServerError(Exceptions.toMessageString(e)); + } catch (RuntimeException e) { log.log(Level.WARNING, "Unexpected error handling '" + request.getUri() + "'", e); return ErrorResponse.internalServerError(Exceptions.toMessageString(e)); |