summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2021-02-22 13:39:03 +0100
committerJon Bratseth <bratseth@gmail.com>2021-02-22 13:39:03 +0100
commit7b5ebc5e9a707c781ca2d6dda189958915f5c942 (patch)
treef95dab7185c27be9cfb98901ce1fc0b45c4654dc
parente5c172375b9ce3630f995b1738c79c6c889d0a53 (diff)
Count empty advice as success
-rw-r--r--node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java
index 310df6e5875..3d6130c4116 100644
--- a/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java
+++ b/node-repository/src/main/java/com/yahoo/vespa/hosted/provision/maintenance/ScalingSuggestionsMaintainer.java
@@ -67,7 +67,7 @@ public class ScalingSuggestionsMaintainer extends NodeRepositoryMaintainer {
Optional<Cluster> cluster = application.cluster(clusterId);
if (cluster.isEmpty()) return true;
var suggestion = autoscaler.suggest(application, cluster.get(), clusterNodes);
- if (suggestion.isEmpty()) return false;
+ if (suggestion.isEmpty()) return true;
// Wait only a short time for the lock to avoid interfering with change deployments
try (Mutex lock = nodeRepository().nodes().lock(applicationId, Duration.ofSeconds(1))) {
// empty suggested resources == keep the current allocation, so we record that