diff options
author | Valerij Fredriksen <freva@users.noreply.github.com> | 2021-03-15 11:53:31 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-03-15 11:53:31 +0100 |
commit | 2544fbabc17c29a209f290b055ffca036a6f17cd (patch) | |
tree | d6bdab929335f6df75611a332d3c2eb6a437b907 | |
parent | aabdab8165bdf6d2c22abdcf0f54f8e952f5c108 (diff) | |
parent | 3b5c73cc54689c971ac0b755f9d8df7385a45c2d (diff) |
Merge pull request #16951 from vespa-engine/mpolden/remove-includes
Remove unused includes
-rw-r--r-- | config-application-package/src/test/java/com/yahoo/config/application/XmlPreprocessorTest.java | 16 | ||||
-rw-r--r-- | configserver/src/main/resources/configserver-app/services.xml | 2 |
2 files changed, 5 insertions, 13 deletions
diff --git a/config-application-package/src/test/java/com/yahoo/config/application/XmlPreprocessorTest.java b/config-application-package/src/test/java/com/yahoo/config/application/XmlPreprocessorTest.java index 549fbdb41ea..7623586679f 100644 --- a/config-application-package/src/test/java/com/yahoo/config/application/XmlPreprocessorTest.java +++ b/config-application-package/src/test/java/com/yahoo/config/application/XmlPreprocessorTest.java @@ -6,13 +6,8 @@ import com.yahoo.config.provision.InstanceName; import com.yahoo.config.provision.RegionName; import org.junit.Test; import org.w3c.dom.Document; -import org.xml.sax.SAXException; -import javax.xml.parsers.ParserConfigurationException; -import javax.xml.stream.XMLStreamException; -import javax.xml.transform.TransformerException; import java.io.File; -import java.io.IOException; import java.io.StringReader; /** @@ -24,7 +19,7 @@ public class XmlPreprocessorTest { private static final File services = new File(appDir, "services.xml"); @Test - public void testPreProcessing() throws IOException, SAXException, ParserConfigurationException, TransformerException { + public void testPreProcessing() throws Exception { String expectedDev = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>" + "<services xmlns:deploy=\"vespa\" xmlns:preprocess=\"properties\" version=\"1.0\">\n" + @@ -49,7 +44,7 @@ public class XmlPreprocessorTest { " </nodes>\n" + " </container>\n" + "</services>"; - TestBase.assertDocument(expectedDev, new XmlPreProcessor(appDir, services, InstanceName.defaultName(), Environment.dev, RegionName.from("default")).run()); + TestBase.assertDocument(expectedDev, new XmlPreProcessor(appDir, services, InstanceName.defaultName(), Environment.dev, RegionName.defaultName()).run()); String expectedStaging = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>" + @@ -75,8 +70,7 @@ public class XmlPreprocessorTest { " </nodes>\n" + " </container>\n" + "</services>"; - // System.out.println(Xml.documentAsString(new XmlPreProcessor(appDir, services, Environment.staging, RegionName.from("default")).run())); - TestBase.assertDocument(expectedStaging, new XmlPreProcessor(appDir, services, InstanceName.defaultName(), Environment.staging, RegionName.from("default")).run()); + TestBase.assertDocument(expectedStaging, new XmlPreProcessor(appDir, services, InstanceName.defaultName(), Environment.staging, RegionName.defaultName()).run()); String expectedUsWest = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>" + @@ -150,7 +144,7 @@ public class XmlPreprocessorTest { } @Test - public void testPropertiesWithOverlappingNames() throws IOException, SAXException, ParserConfigurationException, TransformerException { + public void testPropertiesWithOverlappingNames() throws Exception { String input = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>" + "<services xmlns:deploy=\"vespa\" xmlns:preprocess=\"properties\" version=\"1.0\">" + @@ -190,7 +184,7 @@ public class XmlPreprocessorTest { " <adminserver hostalias=\"node0\"/>" + " </admin>" + "</services>"; - Document docDev = (new XmlPreProcessor(appDir, new StringReader(input), InstanceName.defaultName(), Environment.prod, RegionName.from("default")).run()); + Document docDev = (new XmlPreProcessor(appDir, new StringReader(input), InstanceName.defaultName(), Environment.prod, RegionName.defaultName()).run()); TestBase.assertDocument(expectedProd, docDev); } diff --git a/configserver/src/main/resources/configserver-app/services.xml b/configserver/src/main/resources/configserver-app/services.xml index 3ed9e3a5048..a4ca7081f0b 100644 --- a/configserver/src/main/resources/configserver-app/services.xml +++ b/configserver/src/main/resources/configserver-app/services.xml @@ -56,7 +56,6 @@ <component id="com.yahoo.vespa.configserver.flags.db.FlagsDbImpl" bundle="configserver-flags"/> <preprocess:include file='metrics-packets.xml' required='false' /> - <preprocess:include file='container.xml' required='false' /> <component id="com.yahoo.vespa.service.slobrok.SlobrokMonitorManagerImpl" bundle="service-monitor" /> <component id="com.yahoo.vespa.service.health.HealthMonitorManager" bundle="service-monitor" /> <component id="com.yahoo.vespa.service.manager.UnionMonitorManager" bundle="service-monitor" /> @@ -138,7 +137,6 @@ <http> <server port="19071" id="configserver" /> <preprocess:include file='http-server.xml' required='false' /> - <preprocess:include file='http.xml' required='false' /> </http> <preprocess:include file='athenz-identity-provider.xml' required='false' /> |