diff options
author | HÃ¥kon Hallingstad <hakon@verizonmedia.com> | 2021-10-25 10:50:22 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-10-25 10:50:22 +0200 |
commit | 3f3ff5281e1514ea3870f836a9beff7250a89a44 (patch) | |
tree | 59240a838f3c6308cc24e5e7914590a95a98b04b | |
parent | 832108f7de2bd4065d79198f23fd477c83c12939 (diff) | |
parent | 582b7bf0795c79898187ec5a77011561504f8460 (diff) |
Merge pull request #19712 from vespa-engine/hakonhall/log-version-to-complete-remote-task
Log version to complete remote task
3 files changed, 12 insertions, 2 deletions
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java index ebde8f3a98c..948e416eb53 100644 --- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java +++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java @@ -1004,8 +1004,7 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd // TODO expose and use monotonic clock instead of system clock final long maxDeadlineTimePointMs = timer.getCurrentTimeInMillis() + options.getMaxDeferredTaskVersionWaitTime().toMillis(); for (RemoteClusterControllerTask task : tasksPendingStateRecompute) { - context.log(logger, Level.FINEST, () -> String.format("Adding task of type '%s' to be completed at version %d", - task.getClass().getName(), completeAtVersion)); + context.log(logger, Level.INFO, task + " will be completed at version " + completeAtVersion); taskCompletionQueue.add(new VersionDependentTaskCompletion(completeAtVersion, task, maxDeadlineTimePointMs)); } tasksPendingStateRecompute.clear(); diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/RemoteClusterControllerTask.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/RemoteClusterControllerTask.java index 39ffed1051a..949ad6f56a2 100644 --- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/RemoteClusterControllerTask.java +++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/RemoteClusterControllerTask.java @@ -123,4 +123,6 @@ public abstract class RemoteClusterControllerTask { } } + @Override + public String toString() { return RemoteClusterControllerTask.class.getSimpleName(); } } diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/SetNodeStateRequest.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/SetNodeStateRequest.java index f406ec46ccc..431c207af5c 100644 --- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/SetNodeStateRequest.java +++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/SetNodeStateRequest.java @@ -98,6 +98,15 @@ public class SetNodeStateRequest extends Request<SetResponse> { return super.isFailed() || (resultSet && !result.getWasModified()); } + @Override + public String toString() { + return "SetNodeStateRequest{" + + "node=" + id + "," + + "newState=" + newStates.get("user") + "," + + (probe ? "probe=" + probe + "," : "") + + "}"; + } + static SetResponse setWantedState( ContentCluster cluster, SetUnitStateRequest.Condition condition, |