diff options
author | Harald Musum <musum@yahooinc.com> | 2024-01-05 11:13:47 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-01-05 11:13:47 +0100 |
commit | 8622b5de17bb0559b11e417072f3f999fbf337fd (patch) | |
tree | 1e5a6982e5c83670db2d87bf43d52f8440663fa0 | |
parent | 6f478f8958bb8f4852fa6f059fe2cb34c2afdb00 (diff) | |
parent | 5490d78fb03dc5b05d6f52f311ac623868b234d6 (diff) |
Merge pull request #29810 from vespa-engine/hmusum/cleanup-onnx-model-cost-3
Simplify
-rw-r--r-- | config-model-api/abi-spec.json | 4 | ||||
-rw-r--r-- | config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java | 14 |
2 files changed, 3 insertions, 15 deletions
diff --git a/config-model-api/abi-spec.json b/config-model-api/abi-spec.json index 79283641074..ccd256d0c88 100644 --- a/config-model-api/abi-spec.json +++ b/config-model-api/abi-spec.json @@ -1500,15 +1500,13 @@ ], "methods" : [ "public void <init>(java.lang.String, long, long, com.yahoo.config.model.api.OnnxModelOptions)", - "public void <init>(java.lang.String, long, long, java.util.Optional)", - "public com.yahoo.config.model.api.OnnxModelOptions options()", "public final java.lang.String toString()", "public final int hashCode()", "public final boolean equals(java.lang.Object)", "public java.lang.String modelId()", "public long estimatedCost()", "public long hash()", - "public java.util.Optional onnxModelOptions()" + "public com.yahoo.config.model.api.OnnxModelOptions onnxModelOptions()" ], "fields" : [ ] }, diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java b/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java index 4764d501865..1efd98184cc 100644 --- a/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java +++ b/config-model-api/src/main/java/com/yahoo/config/model/api/OnnxModelCost.java @@ -8,10 +8,10 @@ import com.yahoo.config.provision.ClusterSpec; import java.net.URI; import java.util.Map; -import java.util.Optional; /** * @author bjorncs + * @author hmusum */ public interface OnnxModelCost { @@ -31,17 +31,7 @@ public interface OnnxModelCost { void store(); } - record ModelInfo(String modelId, long estimatedCost, long hash, Optional<OnnxModelOptions> onnxModelOptions) { - - public ModelInfo(String modelId, long estimatedCost, long hash, OnnxModelOptions onnxModelOptions) { - this(modelId, estimatedCost, hash, Optional.of(onnxModelOptions)); - } - - public OnnxModelOptions options() { - return onnxModelOptions.orElseThrow(() -> new IllegalStateException("No onnxModelOptions exist")); - } - - } + record ModelInfo(String modelId, long estimatedCost, long hash, OnnxModelOptions onnxModelOptions) {} static OnnxModelCost disabled() { return new DisabledOnnxModelCost(); } |