diff options
author | Tor Egge <Tor.Egge@broadpark.no> | 2019-03-19 21:08:32 +0100 |
---|---|---|
committer | Tor Egge <Tor.Egge@broadpark.no> | 2019-03-19 21:13:25 +0100 |
commit | 9cca264146d078a3f9760b2e39d263e9d0cf8ffd (patch) | |
tree | 96fb3eb494200f362426973f75a3075bdf9b4f09 | |
parent | 723ba3b84f4df4827686246bbec54a1cee008e23 (diff) |
Stop inlining some constructors and destructors.
7 files changed, 18 insertions, 2 deletions
diff --git a/searchlib/src/apps/vespa-index-inspect/vespa-index-inspect.cpp b/searchlib/src/apps/vespa-index-inspect/vespa-index-inspect.cpp index 83b55c7c698..4e4d90e6871 100644 --- a/searchlib/src/apps/vespa-index-inspect/vespa-index-inspect.cpp +++ b/searchlib/src/apps/vespa-index-inspect/vespa-index-inspect.cpp @@ -138,12 +138,14 @@ public: _ids() { } + ~FieldOptions(); void addField(const vespalib::string &field) { _fields.push_back(field); } bool empty() const { return _ids.empty(); } void validateFields(const Schema &schema); }; +FieldOptions::~FieldOptions() = default; void FieldOptions::validateFields(const Schema &schema) diff --git a/searchlib/src/vespa/searchlib/attribute/floatbase.cpp b/searchlib/src/vespa/searchlib/attribute/floatbase.cpp index ece6a6c33ee..79a639b6100 100644 --- a/searchlib/src/vespa/searchlib/attribute/floatbase.cpp +++ b/searchlib/src/vespa/searchlib/attribute/floatbase.cpp @@ -15,6 +15,8 @@ FloatingPointAttribute::FloatingPointAttribute(const vespalib::string & name, co { } +FloatingPointAttribute::~FloatingPointAttribute() = default; + uint32_t FloatingPointAttribute::clearDoc(DocId doc) { uint32_t removed(0); diff --git a/searchlib/src/vespa/searchlib/attribute/floatbase.h b/searchlib/src/vespa/searchlib/attribute/floatbase.h index 10bd2648aca..9e8b19d1f73 100644 --- a/searchlib/src/vespa/searchlib/attribute/floatbase.h +++ b/searchlib/src/vespa/searchlib/attribute/floatbase.h @@ -16,6 +16,7 @@ class FloatingPointAttribute : public NumericAttribute { public: DECLARE_IDENTIFIABLE_ABSTRACT(FloatingPointAttribute); + ~FloatingPointAttribute() override; template<typename Accessor> bool append(DocId doc, Accessor & ac) { return AttributeVector::append(_changes, doc, ac); diff --git a/searchlib/src/vespa/searchlib/queryeval/fake_result.cpp b/searchlib/src/vespa/searchlib/queryeval/fake_result.cpp index 1df11a0ace0..9786593637e 100644 --- a/searchlib/src/vespa/searchlib/queryeval/fake_result.cpp +++ b/searchlib/src/vespa/searchlib/queryeval/fake_result.cpp @@ -6,7 +6,15 @@ namespace search { namespace queryeval { -FakeResult::~FakeResult() { } +FakeResult::FakeResult() + : _documents(), + _minMaxPostingInfo() +{ +} + +FakeResult::FakeResult(const FakeResult &) = default; + +FakeResult::~FakeResult() = default; std::ostream &operator << (std::ostream &out, const FakeResult &result) { const std::vector<FakeResult::Document> &doc = result.inspect(); diff --git a/searchlib/src/vespa/searchlib/queryeval/fake_result.h b/searchlib/src/vespa/searchlib/queryeval/fake_result.h index 83d5921e4c7..ecb7dd377b9 100644 --- a/searchlib/src/vespa/searchlib/queryeval/fake_result.h +++ b/searchlib/src/vespa/searchlib/queryeval/fake_result.h @@ -45,7 +45,8 @@ private: MinMaxPostingInfo::SP _minMaxPostingInfo; public: - FakeResult() : _documents(), _minMaxPostingInfo() {} + FakeResult(); + FakeResult(const FakeResult &); ~FakeResult(); FakeResult &doc(uint32_t docId) { diff --git a/streamingvisitors/src/vespa/searchvisitor/querywrapper.cpp b/streamingvisitors/src/vespa/searchvisitor/querywrapper.cpp index a4541eb0440..9cb9ed33efb 100644 --- a/streamingvisitors/src/vespa/searchvisitor/querywrapper.cpp +++ b/streamingvisitors/src/vespa/searchvisitor/querywrapper.cpp @@ -43,6 +43,7 @@ QueryWrapper::QueryWrapper(Query & query) : } } +QueryWrapper::~QueryWrapper() = default; } // namespace storage diff --git a/streamingvisitors/src/vespa/searchvisitor/querywrapper.h b/streamingvisitors/src/vespa/searchvisitor/querywrapper.h index 94ba63ef569..53b67349099 100644 --- a/streamingvisitors/src/vespa/searchvisitor/querywrapper.h +++ b/streamingvisitors/src/vespa/searchvisitor/querywrapper.h @@ -57,6 +57,7 @@ private: public: QueryWrapper(search::Query & query); + ~QueryWrapper(); TermList & getTermList() { return _termList; } const TermList & getTermList() const { return _termList; } }; |