Merge pull request #18586 from vespa-engine/jonmv/more-reindexer-synch

Add logging to ReindexingCurator

1 files changed, 10 insertions, 2 deletions

diff --git a/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingCurator.java b/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingCurator.java
index 6074ce99101..67816ad0be1 100644
--- a/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingCurator.java
+++ b/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingCurator.java
@@ -18,6 +18,8 @@ import java.time.Duration;
 import java.time.Instant;
 import java.util.Map;
 import java.util.function.Function;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import static java.util.Objects.requireNonNull;
 import static java.util.stream.Collectors.toUnmodifiableMap;
@@ -29,6 +31,8 @@ import static java.util.stream.Collectors.toUnmodifiableMap;
  */
 public class ReindexingCurator {
 
+    private static final Logger log = Logger.getLogger(ReindexingCurator.class.getName());
+
     private final Curator curator;
     private final ReindexingSerializer serializer;
     private final Duration lockTimeout;
@@ -55,6 +59,7 @@ public class ReindexingCurator {
                     if (ready.get(type).isBefore(now))
                         reindexing = reindexing.with(type, Status.ready(now).running().successful(now));
 
+                log.log(Level.INFO, "Creating initial reindexing status at '" + statusPath(cluster) + "'");
                 writeReindexing(reindexing, cluster);
             }
             catch (ReindexingLockException ignored) {
@@ -64,11 +69,14 @@ public class ReindexingCurator {
     }
 
     public Reindexing readReindexing(String cluster) {
-        return curator.getData(statusPath(cluster)).map(serializer::deserialize)
-                      .orElse(Reindexing.empty());
+        Reindexing reindexing = curator.getData(statusPath(cluster)).map(serializer::deserialize)
+                                       .orElse(Reindexing.empty());
+        log.log(Level.FINE, () -> "Read reindexing status '" + reindexing + "' from '" + statusPath(cluster) + "'");
+        return reindexing;
     }
 
     public void writeReindexing(Reindexing reindexing, String cluster) {
+        log.log(Level.FINE, () -> "Writing reindexing status '" + reindexing + "' to '" + statusPath(cluster) + "'");
         curator.set(statusPath(cluster), serializer.serialize(reindexing));
     }