Merge pull request #18579 from vespa-engine/mpolden/log-failure

Log when image download fails

1 files changed, 6 insertions, 0 deletions

diff --git a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/container/image/ContainerImageDownloader.java b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/container/image/ContainerImageDownloader.java
index c65209698f6..066114dc41f 100644
--- a/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/container/image/ContainerImageDownloader.java
+++ b/node-admin/src/main/java/com/yahoo/vespa/hosted/node/admin/container/image/ContainerImageDownloader.java
@@ -13,6 +13,8 @@ import java.util.Objects;
 import java.util.Set;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 /**
  * Download a container image asynchronously.
@@ -21,6 +23,8 @@ import java.util.concurrent.Executors;
  */
 public class ContainerImageDownloader {
 
+    private static final Logger LOG = Logger.getLogger(ContainerImageDownloader.class.getName());
+
     private final ContainerEngine containerEngine;
 
     private final ExecutorService executorService = Executors.newSingleThreadExecutor(
@@ -42,6 +46,8 @@ public class ContainerImageDownloader {
         executorService.submit(() -> {
             try {
                 containerEngine.pullImage(context, image, registryCredentials);
+            } catch (RuntimeException e) {
+                LOG.log(Level.SEVERE, "Failed to download container image " + image, e);
             } finally {
                 pendingDownloads.remove(image);
             }