summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMorten Tokle <mortent@verizonmedia.com>2021-08-30 12:55:36 +0200
committerMorten Tokle <mortent@verizonmedia.com>2021-08-30 12:55:36 +0200
commitda154c8926facc022abee11cd97f380f3328d6fd (patch)
tree39f570f08297f7b57f982812146786b401456ad2
parentb5d0aa03a886725d9106f0943af539686f49be0f (diff)
Fix tests
-rw-r--r--configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java22
-rw-r--r--configserver/src/test/java/com/yahoo/vespa/config/server/session/PrepareParamsTest.java23
2 files changed, 0 insertions, 45 deletions
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java
index 665b603acfc..07a514f60b5 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/ApplicationRepositoryTest.java
@@ -7,7 +7,6 @@ import com.yahoo.config.ConfigInstance;
import com.yahoo.config.SimpletypesConfig;
import com.yahoo.config.application.api.ApplicationMetaData;
import com.yahoo.config.model.NullConfigModelRegistry;
-import com.yahoo.config.model.api.ApplicationRoles;
import com.yahoo.config.model.application.provider.FilesApplicationPackage;
import com.yahoo.config.provision.AllocatedHosts;
import com.yahoo.config.provision.ApplicationId;
@@ -516,27 +515,6 @@ public class ApplicationRepositoryTest {
}
@Test
- public void deletesApplicationRoles() {
- var tenant = applicationRepository.getTenant(applicationId());
- var applicationId = applicationId(tenant1);
- var prepareParams = new PrepareParams.Builder().applicationId(applicationId)
- .applicationRoles(ApplicationRoles.fromString("hostRole","containerRole")).build();
- deployApp(testApp, prepareParams);
- var approlesStore = new ApplicationRolesStore(tenantRepository.getCurator(), tenant.getPath());
- var appRoles = approlesStore.readApplicationRoles(applicationId);
-
- // App roles present after deploy
- assertTrue(appRoles.isPresent());
- assertEquals("hostRole", appRoles.get().applicationHostRole());
- assertEquals("containerRole", appRoles.get().applicationContainerRole());
-
- assertTrue(applicationRepository.delete(applicationId));
-
- // App roles deleted on application delete
- assertTrue(approlesStore.readApplicationRoles(applicationId).isEmpty());
- }
-
- @Test
public void require_that_provision_info_can_be_read() {
prepareAndActivate(testAppJdiscOnly);
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/session/PrepareParamsTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/session/PrepareParamsTest.java
index f68e79ae266..19f665689a2 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/session/PrepareParamsTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/session/PrepareParamsTest.java
@@ -117,28 +117,6 @@ public class PrepareParamsTest {
}
@Test
- public void testCorrectParsingWithApplicationRoles() throws IOException {
- String req = request + "&" +
- PrepareParams.APPLICATION_HOST_ROLE + "=hostRole&" +
- PrepareParams.APPLICATION_CONTAINER_ROLE + "=containerRole";
- var prepareParams = createParams(req, TenantName.from("foo"));
-
- Optional<ApplicationRoles> applicationRoles = prepareParams.applicationRoles();
- assertTrue(applicationRoles.isPresent());
- assertEquals("hostRole", applicationRoles.get().applicationHostRole());
- assertEquals("containerRole", applicationRoles.get().applicationContainerRole());
-
- // Verify using json object
- var slime = SlimeUtils.jsonToSlime(json);
- var cursor = slime.get();
- cursor.setString(PrepareParams.APPLICATION_HOST_ROLE, "hostRole");
- cursor.setString(PrepareParams.APPLICATION_CONTAINER_ROLE, "containerRole");
-
- PrepareParams prepareParamsJson = PrepareParams.fromJson(SlimeUtils.toJsonBytes(slime), TenantName.from("foo"), Duration.ofSeconds(60));
- assertPrepareParamsEqual(prepareParams, prepareParamsJson);
- }
-
- @Test
public void testQuotaParsing() throws IOException {
var quotaParam = "{\"clusterSize\": 23, \"budget\": 23232323}";
var quotaEncoded = URLEncoder.encode(quotaParam, StandardCharsets.UTF_8);
@@ -239,7 +217,6 @@ public class PrepareParamsTest {
assertEquals(urlParams.endpointCertificateMetadata(), jsonParams.endpointCertificateMetadata());
assertEquals(urlParams.dockerImageRepository(), jsonParams.dockerImageRepository());
assertEquals(urlParams.athenzDomain(), jsonParams.athenzDomain());
- assertEquals(urlParams.applicationRoles(), jsonParams.applicationRoles());
assertEquals(urlParams.quota(), jsonParams.quota());
assertEquals(urlParams.tenantSecretStores(), jsonParams.tenantSecretStores());
}