diff options
author | Ilpo Ruotsalainen <ilpo.ruotsalainen@oath.com> | 2018-11-30 17:03:13 +0100 |
---|---|---|
committer | Ilpo Ruotsalainen <ilpo.ruotsalainen@oath.com> | 2018-11-30 17:03:13 +0100 |
commit | e1d0bc427ee3ff535a8eb72f761155e6ecaea775 (patch) | |
tree | b59c6f628c4cbb219b295d01429965a34895331e /abi-check-plugin | |
parent | fa30c3ee5f8d3191b9fdd9b06fb3314e101337f3 (diff) |
Disable coverage on a few more methods.
Diffstat (limited to 'abi-check-plugin')
6 files changed, 68 insertions, 0 deletions
diff --git a/abi-check-plugin/src/main/java/com/yahoo/abicheck/mojo/AbiCheck.java b/abi-check-plugin/src/main/java/com/yahoo/abicheck/mojo/AbiCheck.java index 67f5715da24..9187b1e45ac 100644 --- a/abi-check-plugin/src/main/java/com/yahoo/abicheck/mojo/AbiCheck.java +++ b/abi-check-plugin/src/main/java/com/yahoo/abicheck/mojo/AbiCheck.java @@ -50,6 +50,8 @@ public class AbiCheck extends AbstractMojo { @Parameter private String specFileName = DEFAULT_SPEC_FILE; + // CLOVER:OFF + // Testing that Gson can read JSON files is not very useful private static Map<String, JavaClassSignature> readSpec(String fileName) throws IOException { try (FileReader reader = new FileReader(fileName)) { TypeToken<Map<String, JavaClassSignature>> typeToken = @@ -59,7 +61,10 @@ public class AbiCheck extends AbstractMojo { return gson.fromJson(reader, typeToken.getType()); } } + // CLOVER:ON + // CLOVER:OFF + // Testing that Gson can write JSON files is not very useful private static void writeSpec(Map<String, JavaClassSignature> signatures, String fileName) throws IOException { Gson gson = new GsonBuilder().setPrettyPrinting().create(); @@ -67,6 +72,7 @@ public class AbiCheck extends AbstractMojo { gson.toJson(signatures, writer); } } + // CLOVER:ON private static boolean matchingClasses(String className, JavaClassSignature expected, JavaClassSignature actual, Log log) { diff --git a/abi-check-plugin/src/test/java/com/yahoo/abicheck/Public.java b/abi-check-plugin/src/test/java/com/yahoo/abicheck/Public.java new file mode 100644 index 00000000000..af39c999cd2 --- /dev/null +++ b/abi-check-plugin/src/test/java/com/yahoo/abicheck/Public.java @@ -0,0 +1,5 @@ +package com.yahoo.abicheck; + +public @interface Public { + +} diff --git a/abi-check-plugin/src/test/java/com/yahoo/abicheck/mojo/AbiCheckTest.java b/abi-check-plugin/src/test/java/com/yahoo/abicheck/mojo/AbiCheckTest.java new file mode 100644 index 00000000000..b8a96debebc --- /dev/null +++ b/abi-check-plugin/src/test/java/com/yahoo/abicheck/mojo/AbiCheckTest.java @@ -0,0 +1,46 @@ +package com.yahoo.abicheck; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +import com.yahoo.abicheck.classtree.ClassFileTree; +import com.yahoo.abicheck.classtree.ClassFileTree.Package; +import com.yahoo.abicheck.mojo.AbiCheck; +import com.yahoo.abicheck.signature.JavaClassSignature; +import java.io.IOException; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.Map; +import org.junit.jupiter.api.Test; + +public class AbiCheckTest { + + @Test + public void testKukkuu() throws IOException { + ClassFileTree.Package rootPkg = mock(ClassFileTree.Package.class); + ClassFileTree.Package subPkg = mock(ClassFileTree.Package.class); + + ClassFileTree.ClassFile rootPkgInfoClass = mock(ClassFileTree.ClassFile.class); + ClassFileTree.ClassFile rootPkgClass = mock(ClassFileTree.ClassFile.class); + ClassFileTree.ClassFile subPkgClass = mock(ClassFileTree.ClassFile.class); + + when(rootPkg.getSubPackages()).thenReturn(Collections.singleton(subPkg)); + when(rootPkg.getClassFiles()).thenReturn(Arrays.asList(rootPkgClass, rootPkgInfoClass)); + when(subPkg.getClassFiles()).thenReturn(Collections.singleton(subPkgClass)); + + when(rootPkgInfoClass.getName()).thenReturn("package-info.class"); + when(rootPkgClass.getName()).thenReturn("Root.class"); + when(subPkgClass.getName()).thenReturn("Sub.class"); + + Map<String, JavaClassSignature> signatures = AbiCheck + .collectPublicAbiSignatures(rootPkg, "com.yahoo.PublicApi"); + +// assertThat(signatures); + } + + private static Collection<Package> buildClassFileTree() { + ClassFileTree.Package root = new ClassFileTree.Package(null, "com"); + } +} diff --git a/abi-check-plugin/src/test/java/root/Root.java b/abi-check-plugin/src/test/java/root/Root.java new file mode 100644 index 00000000000..58fd210159f --- /dev/null +++ b/abi-check-plugin/src/test/java/root/Root.java @@ -0,0 +1,5 @@ +package root; + +public class Root { + +} diff --git a/abi-check-plugin/src/test/java/root/package-info.java b/abi-check-plugin/src/test/java/root/package-info.java new file mode 100644 index 00000000000..149630edd37 --- /dev/null +++ b/abi-check-plugin/src/test/java/root/package-info.java @@ -0,0 +1 @@ +package root;
\ No newline at end of file diff --git a/abi-check-plugin/src/test/java/root/sub/Sub.java b/abi-check-plugin/src/test/java/root/sub/Sub.java new file mode 100644 index 00000000000..c4f330644e9 --- /dev/null +++ b/abi-check-plugin/src/test/java/root/sub/Sub.java @@ -0,0 +1,5 @@ +package root.sub; + +public class Sub { + +} |