diff options
author | Jon Bratseth <jonbratseth@yahoo.com> | 2017-04-21 13:57:01 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-04-21 13:57:01 +0200 |
commit | 6cda45b1f617834bcc389173abfeb022a75f089a (patch) | |
tree | 750c38b6ba44bb04f97597990812f409bd0017c1 /application | |
parent | d4b7836bbfb3c3906a4336138c1d2b090fd5976a (diff) | |
parent | 55edc04268effa7960c4e2b254f423568e943521 (diff) |
Merge pull request #2219 from yahoo/arnej/more-warnings-in-application
Arnej/more warnings in application
Diffstat (limited to 'application')
4 files changed, 11 insertions, 4 deletions
diff --git a/application/pom.xml b/application/pom.xml index 104f27933c9..376a7449afb 100644 --- a/application/pom.xml +++ b/application/pom.xml @@ -108,9 +108,9 @@ <artifactId>maven-compiler-plugin</artifactId> <configuration> <compilerArgs> - <arg>-Xlint:rawtypes</arg> - <arg>-Xlint:unchecked</arg> - <arg>-Xlint:deprecation</arg> + <arg>-Xlint:all</arg> + <arg>-Xlint:-serial</arg> + <arg>-Werror</arg> </compilerArgs> </configuration> </plugin> diff --git a/application/src/main/java/com/yahoo/application/container/Search.java b/application/src/main/java/com/yahoo/application/container/Search.java index 14f1405d40a..dbb655926be 100644 --- a/application/src/main/java/com/yahoo/application/container/Search.java +++ b/application/src/main/java/com/yahoo/application/container/Search.java @@ -41,6 +41,7 @@ public final class Search extends ProcessingBase<Query, Result, Searcher> { } @Override + @SuppressWarnings("deprecation") protected ListenableFuture<Boolean> doProcessAndRender(ComponentSpecification chainSpec, Query request, Renderer<Result> renderer, @@ -51,6 +52,7 @@ public final class Search extends ProcessingBase<Query, Result, Searcher> { } @Override + @SuppressWarnings("deprecation") protected Renderer<Result> doGetRenderer(ComponentSpecification spec) { return handler.getRendererCopy(spec); } diff --git a/application/src/test/java/com/yahoo/application/ApplicationFacade.java b/application/src/test/java/com/yahoo/application/ApplicationFacade.java index 2c8ff05e2cc..41631e67c6d 100644 --- a/application/src/test/java/com/yahoo/application/ApplicationFacade.java +++ b/application/src/test/java/com/yahoo/application/ApplicationFacade.java @@ -155,7 +155,7 @@ public class ApplicationFacade implements AutoCloseable { } @Override - public void close() throws Exception { + public void close() { application.close(); } } diff --git a/application/src/test/java/com/yahoo/application/ApplicationTest.java b/application/src/test/java/com/yahoo/application/ApplicationTest.java index 7671d50bb96..395151d740f 100644 --- a/application/src/test/java/com/yahoo/application/ApplicationTest.java +++ b/application/src/test/java/com/yahoo/application/ApplicationTest.java @@ -54,6 +54,7 @@ public class ApplicationTest { @Test public void minimal_application_can_be_constructed() throws Exception { try (Application application = Application.fromServicesXml("<jdisc version=\"1.0\"/>", Networking.disable)) { + Application unused = application; } } @@ -296,6 +297,7 @@ public class ApplicationTest { public void file_distribution() throws Exception { try (Application application = Application.fromApplicationPackage(new File("src/test/app-packages/filedistribution/"), Networking.disable)) { // Deployment succeeded + Application unused = application; } } @@ -324,6 +326,7 @@ public class ApplicationTest { .container("default", new Application.Builder.Container() .search(true) ))) { + Application unused = app; } } @@ -334,6 +337,7 @@ public class ApplicationTest { HttpClient client = new org.apache.http.impl.client.DefaultHttpClient(); int statusCode = client.execute(new HttpGet("http://localhost:" + httpPort)).getStatusLine().getStatusCode(); fail("Networking.disable is specified, but the network interface is enabled! Got status code: " + statusCode); + Application unused = application; } } @@ -351,6 +355,7 @@ public class ApplicationTest { sb.append(line).append("\n"); } assertTrue(sb.toString().contains("Handler")); + Application unused = application; } } |