Bundle-plugin Scala code converted to Java

6 files changed, 283 insertions, 0 deletions

diff --git a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/AnalyzeClassTest.java b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/AnalyzeClassTest.java
new file mode 100644
index 00000000000..aba6e8f14e8
--- /dev/null
+++ b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/AnalyzeClassTest.java
@@ -0,0 +1,167 @@
+// Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+package com.yahoo.container.plugin.classanalysis;
+
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Base;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.ClassAnnotation;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Derived;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.DummyAnnotation;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Fields;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Interface1;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Interface2;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.MethodAnnotation;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.MethodInvocation;
+import com.yahoo.osgi.annotation.ExportPackage;
+import com.yahoo.osgi.annotation.Version;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+import javax.security.auth.login.LoginException;
+import java.awt.Image;
+import java.awt.image.ImagingOpException;
+import java.awt.image.Kernel;
+import java.util.Optional;
+
+import static com.yahoo.container.plugin.classanalysis.TestUtilities.analyzeClass;
+import static com.yahoo.container.plugin.classanalysis.TestUtilities.classFile;
+import static com.yahoo.container.plugin.classanalysis.TestUtilities.name;
+import static com.yahoo.container.plugin.classanalysis.TestUtilities.throwableMessage;
+import static org.hamcrest.Matchers.allOf;
+import static org.hamcrest.Matchers.anyOf;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.hasItem;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.Matchers.not;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Tests that analysis of class files works.
+ *
+ * @author Tony Vaagenes
+ * @author ollivir
+ */
+public class AnalyzeClassTest {
+    @Test
+    public void require_that_full_class_name_is_returned() {
+        assertThat(analyzeClass(Base.class).getName(), is(name(Base.class)));
+    }
+
+    @Test
+    public void require_that_base_class_is_included() {
+        assertThat(analyzeClass(Derived.class).getReferencedClasses(), hasItem(name(Base.class)));
+    }
+
+    @Test
+    public void require_that_implemented_interfaces_are_included() {
+        assertThat(analyzeClass(Base.class).getReferencedClasses(),
+                allOf(hasItem(name(Interface1.class)), hasItem(name(Interface2.class))));
+    }
+
+    @Test
+    public void require_that_interface_can_be_analyzed() {
+        ClassFileMetaData classMetaData = analyzeClass(Interface1.class);
+
+        assertThat(classMetaData.getName(), is(name(Interface1.class)));
+        assertThat(classMetaData.getReferencedClasses(), hasItem(name(Interface2.class)));
+    }
+
+    @Test
+    public void require_that_return_type_is_included() {
+        assertThat(analyzeClass(Interface1.class).getReferencedClasses(), hasItem(name(Image.class)));
+    }
+
+    @Test
+    public void require_that_parameters_are_included() {
+        assertThat(analyzeClass(Interface1.class).getReferencedClasses(), hasItem(name(Kernel.class)));
+    }
+
+    @Test
+    public void require_that_exceptions_are_included() {
+        assertThat(analyzeClass(Interface1.class).getReferencedClasses(), hasItem(name(ImagingOpException.class)));
+    }
+
+    @Test
+    public void require_that_basic_types_ignored() {
+        assertThat(analyzeClass(Interface1.class).getReferencedClasses(), not(anyOf(hasItem("int"), hasItem("float"))));
+    }
+
+    @Test
+    public void require_that_arrays_of_basic_types_ignored() {
+        assertThat(analyzeClass(Interface1.class).getReferencedClasses(), not(anyOf(hasItem("int[]"), hasItem("int[][]"))));
+    }
+
+    @Test
+    public void require_that_instance_field_types_are_included() {
+        assertThat(analyzeClass(Fields.class).getReferencedClasses(), hasItem(name(String.class)));
+    }
+
+    @Test
+    public void require_that_static_field_types_are_included() {
+        assertThat(analyzeClass(Fields.class).getReferencedClasses(), hasItem(name(java.util.List.class)));
+    }
+
+    @Test
+    public void require_that_field_annotation_is_included() {
+        assertThat(analyzeClass(Fields.class).getReferencedClasses(), hasItem(name(DummyAnnotation.class)));
+    }
+
+    @Test
+    public void require_that_class_annotation_is_included() {
+        assertThat(analyzeClass(ClassAnnotation.class).getReferencedClasses(), hasItem(name(DummyAnnotation.class)));
+    }
+
+    @Test
+    public void require_that_method_annotation_is_included() {
+        assertThat(analyzeClass(MethodAnnotation.class).getReferencedClasses(), hasItem(name(DummyAnnotation.class)));
+    }
+
+    @Test
+    public void require_that_export_package_annotations_are_ignored() {
+        assertThat(Analyze.analyzeClass(classFile("com.yahoo.container.plugin.classanalysis.sampleclasses.package-info"))
+                .getReferencedClasses(), not(anyOf(hasItem(name(ExportPackage.class)), hasItem(name(Version.class)))));
+    }
+
+    @Test
+    public void require_that_export_annotations_are_processed() {
+        assertThat(
+                Analyze.analyzeClass(classFile("com.yahoo.container.plugin.classanalysis.sampleclasses.package-info")).getExportPackage(),
+                is(Optional.of(new ExportPackageAnnotation(3, 1, 4, "TEST_QUALIFIER-2"))));
+    }
+
+    @Rule
+    public ExpectedException expectedException = ExpectedException.none();
+
+    @Test
+    public void require_that_export_annotations_are_validated() {
+        expectedException.expect(RuntimeException.class);
+        expectedException.expectMessage(containsString("invalid/package-info"));
+        expectedException.expectCause(throwableMessage(containsString("qualifier must follow the format")));
+        expectedException.expectCause(throwableMessage(containsString("'EXAMPLE INVALID QUALIFIER'")));
+
+        Analyze.analyzeClass(classFile("com.yahoo.container.plugin.classanalysis.sampleclasses.invalid.package-info"));
+    }
+
+    @Test
+    public void require_that_catch_clauses_are_included() {
+        assertThat(Analyze.analyzeClass(classFile("com.yahoo.container.plugin.classanalysis.sampleclasses.CatchException"))
+                .getReferencedClasses(), hasItem(name(LoginException.class)));
+    }
+
+    @Test
+    public void require_that_class_references_are_included() {
+        assertThat(Analyze.analyzeClass(classFile("com.yahoo.container.plugin.classanalysis.sampleclasses.ClassReference"))
+                .getReferencedClasses(), hasItem(name(Interface1.class)));
+    }
+
+    @Test
+    public void require_that_return_type_of_method_invocations_are_included() {
+        assertThat(analyzeClass(MethodInvocation.class).getReferencedClasses(), hasItem(name(Image.class)));
+    }
+
+    @Test
+    public void require_that_attributes_are_included() {
+        //Uses com/coremedia/iso/Utf8.class from com.googlecode.mp4parser:isoparser:1.0-RC-1
+        assertThat(Analyze.analyzeClass(classFile("class/Utf8")).getReferencedClasses(),
+                hasItem("org.aspectj.weaver.MethodDeclarationLineNumber"));
+    }
+}
diff --git a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/AnalyzeMethodBodyTest.java b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/AnalyzeMethodBodyTest.java
new file mode 100644
index 00000000000..d722f1eba2d
--- /dev/null
+++ b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/AnalyzeMethodBodyTest.java
@@ -0,0 +1,73 @@
+// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+package com.yahoo.container.plugin.classanalysis;
+
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Base;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.ClassWithMethod;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Derived;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Dummy;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Fields;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Interface1;
+import com.yahoo.container.plugin.classanalysis.sampleclasses.Methods;
+import org.junit.Test;
+
+import java.io.PrintStream;
+
+import static com.yahoo.container.plugin.classanalysis.TestUtilities.analyzeClass;
+import static com.yahoo.container.plugin.classanalysis.TestUtilities.name;
+import static org.hamcrest.Matchers.allOf;
+import static org.hamcrest.Matchers.hasItem;
+import static org.hamcrest.Matchers.not;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Tests that classes used in method bodies are included in the imports list.
+ *
+ * @author tonytv
+ */
+public class AnalyzeMethodBodyTest {
+    @Test
+    public void require_that_class_of_locals_are_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(Base.class)));
+    }
+
+    @Test
+    public void require_that_class_of_locals_in_static_method_are_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(Derived.class)));
+    }
+
+    @Test
+    public void require_that_field_references_are_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(),
+                allOf(hasItem(name(java.util.List.class)), hasItem(name(Fields.class))));
+    }
+
+    @Test
+    public void require_that_class_owning_field_is_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(System.class)));
+    }
+
+    @Test
+    public void require_that_class_containing_method_is_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(PrintStream.class)));
+    }
+
+    @Test
+    public void require_that_element_of_new_multidimensional_array_is_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(Interface1.class)));
+    }
+
+    @Test
+    public void require_that_basic_arrays_are_not_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), not(hasItem("int[]")));
+    }
+
+    @Test
+    public void require_that_container_generic_parameters_are_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(Dummy.class)));
+    }
+
+    @Test
+    public void require_that_class_owning_method_handler_is_included() {
+        assertThat(analyzeClass(Methods.class).getReferencedClasses(), hasItem(name(ClassWithMethod.class)));
+    }
+}
diff --git a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/TestUtilities.java b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/TestUtilities.java
new file mode 100644
index 00000000000..6ff6bafd816
--- /dev/null
+++ b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/TestUtilities.java
@@ -0,0 +1,40 @@
+// Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
+package com.yahoo.container.plugin.classanalysis;
+
+import org.hamcrest.Description;
+import org.hamcrest.Matcher;
+import org.hamcrest.TypeSafeMatcher;
+
+import java.io.File;
+
+/**
+ * @author Tony Vaagenes
+ * @author ollivir
+ */
+public class TestUtilities {
+    public static ClassFileMetaData analyzeClass(Class<?> clazz) {
+        return Analyze.analyzeClass(classFile(name(clazz)));
+    }
+
+    public static File classFile(String className) {
+        return new File("target/test-classes/" + className.replace('.', '/') + ".class");
+    }
+
+    public static String name(Class<?> clazz) {
+        return clazz.getName();
+    }
+
+    public static TypeSafeMatcher<Throwable> throwableMessage(final Matcher<String> matcher) {
+        return new TypeSafeMatcher<Throwable>() {
+            @Override
+            protected boolean matchesSafely(Throwable throwable) {
+                return matcher.matches(throwable.getMessage());
+            }
+
+            @Override
+            public void describeTo(Description description) {
+                description.appendText("expects Throwable and a message matching ").appendDescriptionOf(matcher);
+            }
+        };
+    }
+}
diff --git a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/ClassReference.java b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/ClassReference.java
index b4a4f90398f..f650f0f0c7f 100644
--- a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/ClassReference.java
+++ b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/ClassReference.java
@@ -6,6 +6,7 @@ package com.yahoo.container.plugin.classanalysis.sampleclasses;
  */
 public class ClassReference {
     void classReference() {
+        @SuppressWarnings("unused")
         Class<?> clazz = Interface1.class;
     }
 }
diff --git a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/MethodInvocation.java b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/MethodInvocation.java
index 992799e3032..a576c764eec 100644
--- a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/MethodInvocation.java
+++ b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/MethodInvocation.java
@@ -7,6 +7,7 @@ package com.yahoo.container.plugin.classanalysis.sampleclasses;
 public class MethodInvocation {
     void invokeMethod() {
         Interface1 interface1 = null;
+        @SuppressWarnings({ "unused", "null" })
         Object o = interface1.methodSignatureTest(null, null);
     }
 }
diff --git a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/Methods.java b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/Methods.java
index 568a5070961..abe325768fc 100644
--- a/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/Methods.java
+++ b/bundle-plugin/src/test/java/com/yahoo/container/plugin/classanalysis/sampleclasses/Methods.java
@@ -8,6 +8,7 @@ import java.util.Map;
  * Input for class analysis tests.
  * @author tonytv
  */
+@SuppressWarnings("unused")
 public class Methods {
     public void method1() {
         Base b = new Base();