summaryrefslogtreecommitdiffstats
path: root/client
diff options
context:
space:
mode:
authorMartin Polden <mpolden@mpolden.no>2023-05-10 11:20:18 +0200
committerMartin Polden <mpolden@mpolden.no>2023-05-10 11:32:42 +0200
commite4c24cf0526d3c3e575323d49acdd0f91ff6f7f7 (patch)
treeb1f1d33323106c4982323a973ab7995c31215ba5 /client
parent32cc36e3af0b5e24fdcb27ece4e5920042a8c483 (diff)
Always complete non-retriable operations
Diffstat (limited to 'client')
-rw-r--r--client/go/internal/vespa/document/dispatcher.go4
1 files changed, 1 insertions, 3 deletions
diff --git a/client/go/internal/vespa/document/dispatcher.go b/client/go/internal/vespa/document/dispatcher.go
index 00b7dbb411a..7237a87b7e2 100644
--- a/client/go/internal/vespa/document/dispatcher.go
+++ b/client/go/internal/vespa/document/dispatcher.go
@@ -48,8 +48,6 @@ func (op documentOp) resetResult() documentOp {
return op
}
-func (op documentOp) complete() bool { return op.result.Success() || op.attempts == maxAttempts }
-
func NewDispatcher(feeder Feeder, throttler Throttler, breaker CircuitBreaker, output io.Writer, verbose bool) *Dispatcher {
d := &Dispatcher{
feeder: feeder,
@@ -150,7 +148,7 @@ func (d *Dispatcher) processResults() {
d.statsMu.Unlock()
if d.shouldRetry(op, op.result) {
d.enqueue(op.resetResult(), true)
- } else if op.complete() {
+ } else {
d.inflightWg.Done()
}
d.dispatchNext(op.document.Id)