diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-12-06 14:57:58 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-12-06 14:57:58 +0100 |
commit | e728d23b0bf7f2df2106ab51adf4f1ee4133b233 (patch) | |
tree | fadfa4d61b2d6467cd909c868040b927aef69d8f /client | |
parent | 8379322093e419c792337b45625f085efe07aad4 (diff) | |
parent | 90b973be428b6c5ab0be8ee59078dd28e7722b0c (diff) |
Merge pull request #25130 from vespa-engine/arnej/rename-to-jvmopts
avoid using same name for two layered concepts
Diffstat (limited to 'client')
-rw-r--r-- | client/go/jvm/application_container.go | 4 | ||||
-rw-r--r-- | client/go/jvm/container.go | 4 | ||||
-rw-r--r-- | client/go/jvm/options_test.go | 2 | ||||
-rw-r--r-- | client/go/jvm/run.go | 2 | ||||
-rw-r--r-- | client/go/jvm/standalone_container.go | 4 |
5 files changed, 8 insertions, 8 deletions
diff --git a/client/go/jvm/application_container.go b/client/go/jvm/application_container.go index 1cbc8877aa3..b7c9a88b5fd 100644 --- a/client/go/jvm/application_container.go +++ b/client/go/jvm/application_container.go @@ -45,7 +45,7 @@ func (a *ApplicationContainer) Discriminator() string { func (a *ApplicationContainer) addJdiscProperties() { cfgId := a.ConfigId() - opts := a.jvmArgs + opts := a.jvmOpts opts.AddCommonJdiscProperties() containerParentDir := defaults.UnderVespaHome("var/jdisc_container") containerHomeDir := fmt.Sprintf("%s/%s", containerParentDir, a.Discriminator()) @@ -104,7 +104,7 @@ func (a *ApplicationContainer) configureMemory(qc *QrStartConfig) { jvm_directMemorySizeCache = 0 } maxDirectMemorySize := jvm_baseMaxDirectMemorySize + (jvm_heapsize / 8) + jvm_directMemorySizeCache - opts := a.jvmArgs + opts := a.jvmOpts opts.AddOption(fmt.Sprintf("-Xms%dm", jvm_minHeapsize)) opts.AddOption(fmt.Sprintf("-Xmx%dm", jvm_heapsize)) opts.AddOption(fmt.Sprintf("-XX:ThreadStackSize=%d", jvm_stacksize)) diff --git a/client/go/jvm/container.go b/client/go/jvm/container.go index 53ff9f9a809..fd65602e573 100644 --- a/client/go/jvm/container.go +++ b/client/go/jvm/container.go @@ -25,7 +25,7 @@ type Container interface { type containerBase struct { configId string serviceName string - jvmArgs *Options + jvmOpts *Options propsFile string } @@ -34,7 +34,7 @@ func (cb *containerBase) ServiceName() string { } func (cb *containerBase) JvmOptions() *Options { - return cb.jvmArgs + return cb.jvmOpts } func (cb *containerBase) ConfigId() string { diff --git a/client/go/jvm/options_test.go b/client/go/jvm/options_test.go index cfb4e90d5e5..a2763223611 100644 --- a/client/go/jvm/options_test.go +++ b/client/go/jvm/options_test.go @@ -15,7 +15,7 @@ func (*dummyContainer) exportExtraEnv(ps *prog.Spec) {} func newDummyContainer() Container { var dc dummyContainer dc.serviceName = "foo" - dc.jvmArgs = NewOptions(&dc) + dc.jvmOpts = NewOptions(&dc) return &dc } diff --git a/client/go/jvm/run.go b/client/go/jvm/run.go index d0ce2f72988..eb728cabdea 100644 --- a/client/go/jvm/run.go +++ b/client/go/jvm/run.go @@ -27,7 +27,7 @@ func NewApplicationContainer(extraArgs []string) Container { var a ApplicationContainer a.configId = os.Getenv(envvars.VESPA_CONFIG_ID) a.serviceName = os.Getenv(envvars.VESPA_SERVICE_NAME) - a.jvmArgs = NewOptions(&a) + a.jvmOpts = NewOptions(&a) a.configureOptions() for _, x := range extraArgs { a.JvmOptions().AddOption(x) diff --git a/client/go/jvm/standalone_container.go b/client/go/jvm/standalone_container.go index 33007862f58..06d8f041169 100644 --- a/client/go/jvm/standalone_container.go +++ b/client/go/jvm/standalone_container.go @@ -33,7 +33,7 @@ func (a *StandaloneContainer) ConfigId() string { } func (a *StandaloneContainer) configureOptions() { - opts := a.jvmArgs + opts := a.jvmOpts opts.ConfigureCpuCount(0) opts.AddCommonXX() opts.AddOption("-XX:-OmitStackTraceInFastThrow") @@ -52,7 +52,7 @@ func (a *StandaloneContainer) configureOptions() { func NewStandaloneContainer(svcName string) Container { var a StandaloneContainer a.serviceName = svcName - a.jvmArgs = NewOptions(&a) + a.jvmOpts = NewOptions(&a) a.configureOptions() return &a } |