Add TODOs

2 files changed, 9 insertions, 3 deletions

diff --git a/client/go/src/github.com/vespa-engine/vespa/cmd/document.go b/client/go/src/github.com/vespa-engine/vespa/cmd/document.go
index 7056c8e104f..86471a6116f 100644
--- a/client/go/src/github.com/vespa-engine/vespa/cmd/document.go
+++ b/client/go/src/github.com/vespa-engine/vespa/cmd/document.go
@@ -22,7 +22,7 @@ func init() {
 }
 
 var documentCmd = &cobra.Command{
-    Use:   "document document.json",
+    Use:   "document mynamespace/mydocumenttype/myid document.json",
     Short: "Issue document operations (put by default)",
     Long:  `TODO`,
     // TODO: Check args
@@ -35,6 +35,8 @@ var documentPutCmd = &cobra.Command{
     Use:   "put mynamespace/mydocumenttype/myid mydocument.json",
     Short: "Puts the document in the given file",
     Long:  `TODO`,
+    // TODO: This crashes with the above
+    // TODO: Extract document id from the content
     // TODO: Check args
     Run: func(cmd *cobra.Command, args []string) {
         put(args[0], args[1])
@@ -56,7 +58,6 @@ func get(documentId string) {
 }
 
 func put(documentId string, jsonFile string) {
-    // TODO: documentId == mynamespace/music/docid/1
     url, _ := url.Parse(getTarget(documentContext).document + "/document/v1/" + documentId)
 
     header := http.Header{}
@@ -81,9 +82,10 @@ func put(documentId string, jsonFile string) {
     if (response == nil) {
         return
     } else if response.StatusCode == 200 {
-        utils.Success("Success")
+        utils.Success("Success") // TODO: Change to something including document id
     } else if response.StatusCode % 100 == 4 {
         utils.Error("Invalid document JSON")
+        utils.Detail(response.Status)
         // TODO: Output error in body
     } else {
         utils.Error("Error from", strings.ToLower(serviceDescription), "at", request.URL.Host)
diff --git a/client/go/src/github.com/vespa-engine/vespa/cmd/query.go b/client/go/src/github.com/vespa-engine/vespa/cmd/query.go
index 11901fc8355..7df475f08fe 100644
--- a/client/go/src/github.com/vespa-engine/vespa/cmd/query.go
+++ b/client/go/src/github.com/vespa-engine/vespa/cmd/query.go
@@ -32,6 +32,9 @@ var queryCmd = &cobra.Command{
 }
 
 func query(argument string) {
+    // TODO: url-encode query
+    // TODO: assume yql not query. or autodetect
+
     if ! strings.Contains(argument, "query=") {
         argument = "?query=" + argument
     }
@@ -48,6 +51,7 @@ func query(argument string) {
 
     defer response.Body.Close()
     if (response.StatusCode == 200) {
+        // TODO: Pretty-print body
         scanner := bufio.NewScanner(response.Body)
         for ;scanner.Scan(); {
             utils.Print(scanner.Text())