Minor cleanup

GC dead code, optimize imports, fix unnecessary throws statements

25 files changed, 38 insertions, 108 deletions

diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterEvent.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterEvent.java
index 1853a024e11..f7b5b5ee523 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterEvent.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterEvent.java
@@ -28,10 +28,6 @@ public class ClusterEvent implements Event{
         return description;
     }
 
-    public Type getType() {
-        return type;
-    }
-
     @Override
     public String toString() {
         return "Cluster event type " + type + " @" + timeMs + ": " + description;
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateBundle.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateBundle.java
index e55f3d4592b..7062f67830b 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateBundle.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateBundle.java
@@ -3,7 +3,14 @@ package com.yahoo.vespa.clustercontroller.core;
 
 import com.yahoo.vdslib.state.ClusterState;
 
-import java.util.*;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.TreeMap;
+import java.util.TreeSet;
 import java.util.function.Function;
 import java.util.stream.Collectors;
 
@@ -194,12 +201,6 @@ public class ClusterStateBundle {
 
     public static ClusterStateBundle of(AnnotatedClusterState baselineState,
                                         Map<String, AnnotatedClusterState> derivedBucketSpaceStates,
-                                        boolean deferredActivation) {
-        return new ClusterStateBundle(baselineState, derivedBucketSpaceStates, null, deferredActivation);
-    }
-
-    public static ClusterStateBundle of(AnnotatedClusterState baselineState,
-                                        Map<String, AnnotatedClusterState> derivedBucketSpaceStates,
                                         FeedBlock feedBlock,
                                         boolean deferredActivation) {
         return new ClusterStateBundle(baselineState, derivedBucketSpaceStates, feedBlock, deferredActivation);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/DistributorNodeInfo.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/DistributorNodeInfo.java
index fb9a4cf4604..24e3d0de977 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/DistributorNodeInfo.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/DistributorNodeInfo.java
@@ -4,8 +4,6 @@ package com.yahoo.vespa.clustercontroller.core;
 import com.yahoo.vdslib.distribution.Distribution;
 import com.yahoo.vdslib.state.Node;
 import com.yahoo.vdslib.state.NodeType;
-import com.yahoo.vespa.clustercontroller.core.hostinfo.HostInfo;
-import com.yahoo.vespa.clustercontroller.core.hostinfo.StorageNodeStatsBridge;
 
 /**
  * Class encapsulating what the Cluster Controller knows about a distributor node. Most of the information is
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLog.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLog.java
index 0058d12f640..e64e684ed70 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLog.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLog.java
@@ -15,7 +15,7 @@ import java.util.logging.Logger;
 
 public class EventLog implements EventLogInterface {
 
-    public static Logger log = Logger.getLogger(EventLog.class.getName());
+    public static final Logger log = Logger.getLogger(EventLog.class.getName());
 
     private final Timer timer;
     private final LinkedList<Event> eventLog = new LinkedList<>();
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLogInterface.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLogInterface.java
index 382025bb67b..e4538162f64 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLogInterface.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/EventLogInterface.java
@@ -3,8 +3,6 @@ package com.yahoo.vespa.clustercontroller.core;
 
 import com.yahoo.vdslib.state.Node;
 
-import java.util.List;
-
 public interface EventLogInterface {
 
     void add(Event e);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
index ff0d8b87e92..cef1b41b775 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
@@ -257,7 +257,7 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
 
     public int getRpcPort() { return rpcServer.getPort(); }
 
-    public void shutdown() throws InterruptedException, java.io.IOException {
+    public void shutdown() throws InterruptedException {
         if (runner != null && isRunning()) {
             context.log(logger, Level.INFO, "Joining event thread.");
             running.set(false);
@@ -393,14 +393,8 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
     }
 
     private void storeClusterStateMetaDataToZooKeeper(ClusterStateBundle stateBundle) {
-        try {
-            database.saveLatestSystemStateVersion(databaseContext, stateBundle.getVersion());
-            database.saveLatestClusterStateBundle(databaseContext, stateBundle);
-        } catch (InterruptedException e) {
-            // Rethrow as RuntimeException to propagate exception up to main thread method.
-            // Don't want to hide failures to write cluster state version.
-            throw new RuntimeException("ZooKeeper write interrupted", e);
-        }
+        database.saveLatestSystemStateVersion(databaseContext, stateBundle.getVersion());
+        database.saveLatestClusterStateBundle(databaseContext, stateBundle);
     }
 
     /**
@@ -408,7 +402,7 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
      * The keys in the given map are indices of fleet controllers.
      * The values are what fleetcontroller that fleetcontroller wants to
      * become master.
-     *
+     * <p
      * If more than half the fleetcontrollers want a node to be master and
      * that node also wants itself as master, that node is the single master.
      * If this condition is not met, there is currently no master.
@@ -450,7 +444,7 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
     }
 
     /** Called when all distributors have acked newest cluster state version. */
-    public void handleAllDistributorsInSync(DatabaseHandler database, DatabaseHandler.DatabaseContext dbContext) throws InterruptedException {
+    public void handleAllDistributorsInSync(DatabaseHandler database, DatabaseHandler.DatabaseContext dbContext) {
         Set<ConfiguredNode> nodes = new HashSet<>(cluster.clusterInfo().getConfiguredNodes().values());
         // TODO wouldn't it be better to always get bundle information from the state broadcaster?
         var currentBundle = stateVersionTracker.getVersionedClusterStateBundle();
@@ -512,12 +506,6 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
             rpcServer.setSlobrokConnectionSpecs(options.slobrokConnectionSpecs(), options.rpcPort());
         }
 
-        try {
-            statusPageServer.setPort(options.httpPort());
-        } catch (Exception e) {
-            context.log(logger, Level.WARNING, "Failed to initialize status server socket. This may be natural if cluster has altered the services running on this node: " + e.getMessage());
-        }
-
         long currentTime = timer.getCurrentTimeInMillis();
         nextStateSendTime = Math.min(currentTime + options.minTimeBetweenNewSystemStates(), nextStateSendTime);
     }
@@ -632,8 +620,6 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
     private boolean updateMasterElectionState() {
         try {
             return masterElectionHandler.watchMasterElection(database, databaseContext);
-        } catch (InterruptedException e) {
-            throw new RuntimeException(e);
         } catch (Exception e) {
             context.log(logger, Level.WARNING, "Failed to watch master election: " + e);
         }
@@ -1116,7 +1102,7 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
         synchronized (monitor) { monitor.notifyAll(); }
     }
 
-    public DatabaseHandler.DatabaseContext databaseContext = new DatabaseHandler.DatabaseContext() {
+    public final DatabaseHandler.DatabaseContext databaseContext = new DatabaseHandler.DatabaseContext() {
         @Override
         public ContentCluster getCluster() { return cluster; }
         @Override
@@ -1207,10 +1193,6 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
 
     public ContentCluster getCluster() { return cluster; }
 
-    public EventLog getEventLog() {
-        return eventLog;
-    }
-
     public StatusHandler.ContainerStatusPageServer statusPageServer() { return statusPageServer; }
 
 }
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetControllerOptions.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetControllerOptions.java
index 21ccfb2750e..1541e1a4218 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetControllerOptions.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetControllerOptions.java
@@ -469,10 +469,6 @@ public class FleetControllerOptions {
             return this;
         }
 
-        public String[] slobrokConnectionSpecs() {
-            return slobrokConnectionSpecs;
-        }
-
         public Builder setSlobrokConnectionSpecs(String[] slobrokConnectionSpecs) {
             Objects.requireNonNull(slobrokConnectionSpecs, "slobrokConnectionSpecs cannot be null");
             this.slobrokConnectionSpecs = slobrokConnectionSpecs;
@@ -664,10 +660,6 @@ public class FleetControllerOptions {
             return this;
         }
 
-        public double minMergeCompletionRatio() {
-            return minMergeCompletionRatio;
-        }
-
         public Builder setMinMergeCompletionRatio(double minMergeCompletionRatio) {
             this.minMergeCompletionRatio = minMergeCompletionRatio;
             return this;
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/MasterElectionHandler.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/MasterElectionHandler.java
index dfc328346bb..b041e6b14f8 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/MasterElectionHandler.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/MasterElectionHandler.java
@@ -120,8 +120,7 @@ public class MasterElectionHandler implements MasterInterface {
 
     public boolean isAmongNthFirst(int first) { return (nextInLineCount < first); }
 
-    public boolean watchMasterElection(DatabaseHandler database,
-                                       DatabaseHandler.DatabaseContext dbContext) throws InterruptedException {
+    public boolean watchMasterElection(DatabaseHandler database, DatabaseHandler.DatabaseContext dbContext) {
         if (totalCount == 1 && !usingZooKeeper) {
             return false; // Allow single configured node to become master implicitly if no ZK configured
         }
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeInfo.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeInfo.java
index d7aac1c26fa..069139b8c9e 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeInfo.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeInfo.java
@@ -241,8 +241,6 @@ abstract public class NodeInfo implements Comparable<NodeInfo> {
         return node.getIndex();
     }
 
-    public ContentCluster getCluster() { return cluster; }
-
     /** Returns true if the node is registered in slobrok */
     public boolean isInSlobrok() { return lastSeenInSlobrok == null; }
 
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java
index 0efba56284b..72bd5148f11 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java
@@ -14,11 +14,10 @@ import java.util.List;
 import java.util.Map;
 import java.util.TreeMap;
 import java.util.logging.Logger;
-import java.util.stream.Collectors;
 
 public class SystemStateBroadcaster {
 
-    private static Logger log = Logger.getLogger(SystemStateBroadcaster.class.getName());
+    private static final Logger log = Logger.getLogger(SystemStateBroadcaster.class.getName());
 
     private final FleetControllerContext context;
     private final Timer timer;
@@ -261,7 +260,7 @@ public class SystemStateBroadcaster {
         lastStateVersionBundleAcked = clusterStateBundle.getVersion();
     }
 
-    private void markCurrentClusterStateAsConverged(DatabaseHandler database, DatabaseHandler.DatabaseContext dbContext, FleetController fleetController) throws InterruptedException {
+    private void markCurrentClusterStateAsConverged(DatabaseHandler database, DatabaseHandler.DatabaseContext dbContext, FleetController fleetController) {
         context.log(log, Level.FINE, "All distributors have newest clusterstate, updating start timestamps in zookeeper and clearing them from cluster state");
         lastClusterStateVersionConverged = clusterStateBundle.getVersion();
         lastClusterStateBundleConverged = clusterStateBundle;
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java
index 408c10e81b1..efb97a4a69e 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java
@@ -91,8 +91,11 @@ public class DatabaseHandler {
     private boolean lostZooKeeperConnectionEvent = false;
     private Map<Integer, Integer> masterDataEvent = null;
 
-    public DatabaseHandler(FleetControllerContext fleetControllerContext, DatabaseFactory databaseFactory, Timer timer, String zooKeeperAddress, Object monitor) throws InterruptedException
-    {
+    public DatabaseHandler(FleetControllerContext fleetControllerContext,
+                           DatabaseFactory databaseFactory,
+                           Timer timer,
+                           String zooKeeperAddress,
+                           Object monitor) {
         this.fleetControllerContext = fleetControllerContext;
         this.databaseFactory = databaseFactory;
         this.timer = timer;
@@ -356,7 +359,7 @@ public class DatabaseHandler {
         }
     }
 
-    public void saveLatestSystemStateVersion(DatabaseContext databaseContext, int version) throws InterruptedException {
+    public void saveLatestSystemStateVersion(DatabaseContext databaseContext, int version) {
         fleetControllerContext.log(logger, Level.FINE, () -> "Checking if latest system state version has been updated and need to be stored.");
         // Schedule a write if one of the following is true:
         //   - There is already a pending vote to be written, that may have been written already without our knowledge
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/ZooKeeperDatabase.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/ZooKeeperDatabase.java
index ea745a56066..042d091fdbb 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/ZooKeeperDatabase.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/ZooKeeperDatabase.java
@@ -245,7 +245,7 @@ public class ZooKeeperDatabase extends Database {
                 if (!toStore.equals(nodeState)) {
                     log.warning("Attempted to store wanted state with more than just a main state. Extra data stripped. Original data '" + nodeState.serialize(true));
                 }
-                sb.append(node.toString()).append(':').append(toStore.serialize(true)).append('\n');
+                sb.append(node).append(':').append(toStore.serialize(true)).append('\n');
             }
         }
         byte[] val = sb.toString().getBytes(utf8);
@@ -299,7 +299,7 @@ public class ZooKeeperDatabase extends Database {
             Long timestamp = timestamps.get(n);
             sb.append(n.toString()).append(':').append(timestamp).append('\n');
         }
-        byte val[] = sb.toString().getBytes(utf8);
+        byte[] val = sb.toString().getBytes(utf8);
         try{
             context.log(log, Level.FINE, () -> "Storing start timestamps at '" + paths.startTimestamps() + "'");
             session.setData(paths.startTimestamps(), val, -1);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/ContentNode.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/ContentNode.java
index 945745b7ff5..45f67c09ac4 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/ContentNode.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/ContentNode.java
@@ -13,7 +13,7 @@ import java.util.Optional;
  */
 public class ContentNode {
     @JsonProperty("resource-usage")
-    private Map<String, ResourceUsage> resourceUsage = new HashMap<>();
+    private final Map<String, ResourceUsage> resourceUsage = new HashMap<>();
 
     public Map<String, ResourceUsage> getResourceUsage() {
         return Collections.unmodifiableMap(resourceUsage);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/HostInfo.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/HostInfo.java
index 1a11e32c9b8..9314eb61bf2 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/HostInfo.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/HostInfo.java
@@ -16,7 +16,7 @@ import java.util.logging.Logger;
  */
 public class HostInfo {
 
-    private static Logger log = Logger.getLogger(HostInfo.class.getName());
+    private static final Logger log = Logger.getLogger(HostInfo.class.getName());
     private static final ObjectMapper mapper = new ObjectMapper();
     private String rawCreationString = "NOT SET";
     static {
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/StorageNodeStatsBridge.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/StorageNodeStatsBridge.java
index 73f504b6004..aaaf44c3f3f 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/StorageNodeStatsBridge.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/hostinfo/StorageNodeStatsBridge.java
@@ -4,7 +4,6 @@ package com.yahoo.vespa.clustercontroller.core.hostinfo;
 import com.yahoo.vespa.clustercontroller.core.*;
 
 import java.util.HashMap;
-import java.util.List;
 import java.util.Map;
 
 /**
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/VerboseReport.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/VerboseReport.java
deleted file mode 100644
index c18afb811fa..00000000000
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/restapiv2/requests/VerboseReport.java
+++ /dev/null
@@ -1,6 +0,0 @@
-// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
-package com.yahoo.vespa.clustercontroller.core.restapiv2.requests;
-
-public enum VerboseReport {
-    STATISTICS
-}
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCActivateClusterStateVersionWaiter.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCActivateClusterStateVersionWaiter.java
index fe441a0eb91..1e7591a9aaa 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCActivateClusterStateVersionWaiter.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCActivateClusterStateVersionWaiter.java
@@ -7,7 +7,6 @@ import com.yahoo.jrt.RequestWaiter;
 import com.yahoo.vespa.clustercontroller.core.ActivateClusterStateVersionRequest;
 import com.yahoo.vespa.clustercontroller.core.Communicator;
 import com.yahoo.vespa.clustercontroller.core.NodeInfo;
-import com.yahoo.vespa.clustercontroller.core.Timer;
 
 /**
  * Binds together the reply received for a particular cluster state activation RPC and
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCCommunicator.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCCommunicator.java
index 58bbd03044f..fc2a8eda7e9 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCCommunicator.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCCommunicator.java
@@ -135,7 +135,7 @@ public class RPCCommunicator implements Communicator {
 
     @Override
     public void setSystemState(ClusterStateBundle stateBundle, NodeInfo node, Waiter<SetClusterStateRequest> externalWaiter) {
-        RPCSetClusterStateWaiter waiter = new RPCSetClusterStateWaiter(externalWaiter, timer);
+        RPCSetClusterStateWaiter waiter = new RPCSetClusterStateWaiter(externalWaiter);
         ClusterState baselineState = stateBundle.getBaselineClusterState();
 
         Target connection = getConnection(node);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCSetClusterStateWaiter.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCSetClusterStateWaiter.java
index 41fc7f67fbb..eaeec8abae7 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCSetClusterStateWaiter.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RPCSetClusterStateWaiter.java
@@ -7,7 +7,6 @@ import com.yahoo.jrt.RequestWaiter;
 import com.yahoo.vespa.clustercontroller.core.Communicator;
 import com.yahoo.vespa.clustercontroller.core.NodeInfo;
 import com.yahoo.vespa.clustercontroller.core.SetClusterStateRequest;
-import com.yahoo.vespa.clustercontroller.core.Timer;
 
 /**
  * Waiter class for set cluster state RPC commands.
@@ -15,11 +14,9 @@ import com.yahoo.vespa.clustercontroller.core.Timer;
 public class RPCSetClusterStateWaiter implements RequestWaiter {
 
     SetClusterStateRequest request;
-    Timer timer;
     Communicator.Waiter<SetClusterStateRequest> waiter;
 
-    public RPCSetClusterStateWaiter(Communicator.Waiter<SetClusterStateRequest> waiter, Timer timer) {
-        this.timer = timer;
+    public RPCSetClusterStateWaiter(Communicator.Waiter<SetClusterStateRequest> waiter) {
         this.waiter = waiter;
     }
 
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/RunDataExtractor.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/RunDataExtractor.java
deleted file mode 100644
index 599931ba13c..00000000000
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/RunDataExtractor.java
+++ /dev/null
@@ -1,15 +0,0 @@
-// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
-package com.yahoo.vespa.clustercontroller.core.status;
-
-import com.yahoo.vespa.clustercontroller.core.ContentCluster;
-import com.yahoo.vespa.clustercontroller.core.FleetControllerOptions;
-
-/**
- * @author Haakon Humberset
- */
-public interface RunDataExtractor {
-
-    FleetControllerOptions getOptions();
-    ContentCluster getCluster();
-
-}
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/StatusHandler.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/StatusHandler.java
index 302832e4542..a8a858b5d31 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/StatusHandler.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/StatusHandler.java
@@ -6,7 +6,6 @@ import com.yahoo.vespa.clustercontroller.core.status.statuspage.StatusPageServer
 import com.yahoo.vespa.clustercontroller.utils.communication.http.HttpRequest;
 import com.yahoo.vespa.clustercontroller.utils.communication.http.HttpRequestHandler;
 import com.yahoo.vespa.clustercontroller.utils.communication.http.HttpResult;
-import java.io.IOException;
 import java.io.StringWriter;
 import java.nio.charset.StandardCharsets;
 import java.util.Map;
@@ -35,8 +34,7 @@ public class StatusHandler implements HttpRequestHandler {
         private final Object answerMonitor = new Object();
 
         public int getPort() { return 0; }
-        public void shutdown() throws InterruptedException, IOException {}
-        public void setPort(int port) {}
+        public void shutdown() {}
         public StatusPageServer.HttpRequest getCurrentHttpRequest() {
             synchronized (answerMonitor) {
                 StatusPageServer.HttpRequest r = request;
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/HtmlTable.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/HtmlTable.java
index af059809815..b2c12cbbdcf 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/HtmlTable.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/HtmlTable.java
@@ -10,7 +10,8 @@ public class HtmlTable {
 
     int border = 1;
     int cellSpacing = 0;
-    enum Orientation { LEFT, CENTER, RIGHT };
+    enum Orientation { LEFT, CENTER, RIGHT }
+
     public static class CellProperties {
         Integer backgroundColor;
         Integer colSpan; // Colspan 0 indicate rest of table
@@ -59,7 +60,7 @@ public class HtmlTable {
         Row addProperties(CellProperties p) { rowProperties.add(p); return this; }
     }
 
-    private ArrayList<Row> cells = new ArrayList<Row>();
+    private final ArrayList<Row> cells = new ArrayList<Row>();
 
     public HtmlTable() {
     }
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageResponse.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageResponse.java
index 87aa1fc497c..0701403732a 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageResponse.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageResponse.java
@@ -10,10 +10,9 @@ import java.io.OutputStreamWriter;
 
 public class StatusPageResponse {
 
-    private ByteArrayOutputStream output = new ByteArrayOutputStream();
+    private final ByteArrayOutputStream output = new ByteArrayOutputStream();
     private String contentType;
     private ResponseCode responseCode = ResponseCode.OK;
-    private boolean clientCachingEnabled = false;
 
     public enum ResponseCode {
         OK(200, "OK"),
@@ -61,14 +60,6 @@ public class StatusPageResponse {
         this.responseCode = responseCode;
     }
 
-    public boolean isClientCachingEnabled() {
-        return clientCachingEnabled;
-    }
-
-    public void setClientCachingEnabled(boolean clientCachingEnabled) {
-        this.clientCachingEnabled = clientCachingEnabled;
-    }
-
     public void writeHtmlHeader(StringBuilder content, String title) {
         String escaped_title = HtmlEscapers.htmlEscaper().escape(title);
         content.append("<html>\n")
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageServer.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageServer.java
index 1bd011993a0..ec5760181e5 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageServer.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/StatusPageServer.java
@@ -24,7 +24,7 @@ public class StatusPageServer {
         private final String request;
         private String pathPrefix = "";
         private final Map<String, String> params = new HashMap<String, String>();
-        private String path;
+        private final String path;
 
         static Pattern pathPattern;
         static {
@@ -112,7 +112,7 @@ public class StatusPageServer {
             }
         }
 
-        private List<PatternRouting> patterns = new ArrayList<>();
+        private final List<PatternRouting> patterns = new ArrayList<>();
 
         public void addHandler(Pattern pattern, RequestHandler handler) {
             patterns.add(new PatternRouting(pattern, handler));
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/VdsClusterHtmlRenderer.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/VdsClusterHtmlRenderer.java
index 547647e82e6..b350467c284 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/VdsClusterHtmlRenderer.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/status/statuspage/VdsClusterHtmlRenderer.java
@@ -58,7 +58,7 @@ public class VdsClusterHtmlRenderer {
         public void addTable(final StringBuilder destination, final long stableStateTimePeriode) {
             destination.append(contentBuilder);
 
-            destination.append(table.toString())
+            destination.append(table)
                     .append("<p>")
                     .append("<p>");
             addFooter(destination, stableStateTimePeriode);