Use plural for methods returning collection

11 files changed, 48 insertions, 48 deletions

diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterInfo.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterInfo.java
index c25dd5a5965..da5114b8675 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterInfo.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterInfo.java
@@ -40,11 +40,11 @@ public class ClusterInfo {
     /** Returns information about the given node id, or null if this node does not exist */
     public NodeInfo getNodeInfo(Node node) { return allNodeInfo.get(node); }
 
-    Collection<DistributorNodeInfo> getDistributorNodeInfo() { return Collections.unmodifiableCollection(distributorNodeInfo.values()); }
+    Collection<DistributorNodeInfo> getDistributorNodeInfos() { return Collections.unmodifiableCollection(distributorNodeInfo.values()); }
 
-    Collection<StorageNodeInfo> getStorageNodeInfo() { return Collections.unmodifiableCollection(storageNodeInfo.values()); }
+    Collection<StorageNodeInfo> getStorageNodeInfos() { return Collections.unmodifiableCollection(storageNodeInfo.values()); }
 
-    Collection<NodeInfo> getAllNodeInfo() { return Collections.unmodifiableCollection(allNodeInfo.values()); }
+    Collection<NodeInfo> getAllNodeInfos() { return Collections.unmodifiableCollection(allNodeInfo.values()); }
 
     /** Returns the configured nodes of this as a read-only map indexed on node index (distribution key) */
     Map<Integer, ConfiguredNode> getConfiguredNodes() { return Collections.unmodifiableMap(nodes); }
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateGenerator.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateGenerator.java
index f984c3cb3a2..75c6dbe6cec 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateGenerator.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ClusterStateGenerator.java
@@ -129,7 +129,7 @@ public class ClusterStateGenerator {
         final ClusterState workingState = ClusterState.emptyState();
         final Map<Node, NodeStateReason> nodeStateReasons = new HashMap<>();
 
-        for (final NodeInfo nodeInfo : cluster.getNodeInfo()) {
+        for (final NodeInfo nodeInfo : cluster.getNodeInfos()) {
             final NodeState nodeState = computeEffectiveNodeState(nodeInfo, params, nodeStateReasons);
             workingState.setNodeState(nodeInfo.getNode(), nodeState);
         }
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ContentCluster.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ContentCluster.java
index fabc4999fe5..579417cb8ae 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ContentCluster.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/ContentCluster.java
@@ -104,7 +104,7 @@ public class ContentCluster {
 
     public void setDistribution(Distribution distribution) {
         this.distribution = distribution;
-        for (NodeInfo info : clusterInfo.getAllNodeInfo()) {
+        for (NodeInfo info : clusterInfo.getAllNodeInfos()) {
             info.setGroup(distribution);
         }
     }
@@ -128,7 +128,7 @@ public class ContentCluster {
     }
 
     public void clearStates() {
-        for (NodeInfo info : clusterInfo.getAllNodeInfo()) {
+        for (NodeInfo info : clusterInfo.getAllNodeInfos()) {
             info.setReportedState(null, 0);
         }
     }
@@ -145,8 +145,8 @@ public class ContentCluster {
         return clusterInfo.getConfiguredNodes();
     }
 
-    public Collection<NodeInfo> getNodeInfo() {
-        return Collections.unmodifiableCollection(clusterInfo.getAllNodeInfo());
+    public Collection<NodeInfo> getNodeInfos() {
+        return Collections.unmodifiableCollection(clusterInfo.getAllNodeInfos());
     }
 
     public ClusterInfo clusterInfo() { return clusterInfo; }
@@ -158,7 +158,7 @@ public class ContentCluster {
     public String toString() {
         StringBuilder sb = new StringBuilder();
         sb.append("ContentCluster(").append(clusterName).append(") {");
-        for (NodeInfo node : clusterInfo.getAllNodeInfo()) {
+        for (NodeInfo node : clusterInfo.getAllNodeInfos()) {
             sb.append("\n  ").append(node);
         }
         sb.append("\n}");
@@ -197,14 +197,14 @@ public class ContentCluster {
         switch (state) {
             case MAINTENANCE:  // Orchestrator's ALLOWED_TO_BE_DOWN
             case DOWN:  // Orchestrator's PERMANENTLY_DOWN
-                return clusterInfo.getStorageNodeInfo().stream()
-                        .filter(storageNodeInfo -> {
+                return clusterInfo.getStorageNodeInfos().stream()
+                                  .filter(storageNodeInfo -> {
                             NodeState userWantedState = storageNodeInfo.getUserWantedState();
                             return userWantedState.getState() == state &&
                                     Objects.equals(userWantedState.getDescription(), ORCHESTRATOR_RESERVED_DESCRIPTION);
                         })
-                        .map(NodeInfo::getNodeIndex)
-                        .collect(Collectors.toList());
+                                  .map(NodeInfo::getNodeIndex)
+                                  .collect(Collectors.toList());
             default:
                 // Note: There is no trace left if the Orchestrator set the state to UP, so that's handled
                 // like any other state:
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
index 3137dfff606..1d98b9fe831 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
@@ -380,7 +380,7 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd
         ClusterState baselineState = stateBundle.getBaselineClusterState();
         newStates.add(stateBundle);
         metricUpdater.updateClusterStateMetrics(cluster, baselineState,
-                ResourceUsageStats.calculateFrom(cluster.getNodeInfo(), options.clusterFeedBlockLimit, stateBundle.getFeedBlock()));
+                ResourceUsageStats.calculateFrom(cluster.getNodeInfos(), options.clusterFeedBlockLimit, stateBundle.getFeedBlock()));
         lastMetricUpdateCycleCount = cycleCount;
         systemStateBroadcaster.handleNewClusterStates(stateBundle);
         // Iff master, always store new version in ZooKeeper _before_ publishing to any
@@ -399,7 +399,7 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd
             ClusterStateBundle stateBundle = stateVersionTracker.getVersionedClusterStateBundle();
             ClusterState baselineState = stateBundle.getBaselineClusterState();
             metricUpdater.updateClusterStateMetrics(cluster, baselineState,
-                    ResourceUsageStats.calculateFrom(cluster.getNodeInfo(), options.clusterFeedBlockLimit, stateBundle.getFeedBlock()));
+                    ResourceUsageStats.calculateFrom(cluster.getNodeInfos(), options.clusterFeedBlockLimit, stateBundle.getFeedBlock()));
             lastMetricUpdateCycleCount = cycleCount;
             return true;
         } else {
@@ -806,10 +806,10 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd
         if (bundle == null) {
             return List.of();
         }
-        return cluster.getNodeInfo().stream().
-                filter(n -> effectiveActivatedStateVersion(n, bundle) < version).
-                map(NodeInfo::getNode).
-                collect(Collectors.toList());
+        return cluster.getNodeInfos().stream().
+                      filter(n -> effectiveActivatedStateVersion(n, bundle) < version).
+                      map(NodeInfo::getNode).
+                      collect(Collectors.toList());
     }
 
     private static <E> String stringifyListWithLimits(List<E> list, int limit) {
@@ -939,7 +939,7 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd
                     .stateDeriver(createBucketSpaceStateDeriver())
                     .deferredActivation(options.enableTwoPhaseClusterStateActivation)
                     .feedBlock(createResourceExhaustionCalculator()
-                            .inferContentClusterFeedBlockOrNull(cluster.getNodeInfo()))
+                            .inferContentClusterFeedBlockOrNull(cluster.getNodeInfos()))
                     .deriveAndBuild();
             stateVersionTracker.updateLatestCandidateStateBundle(candidateBundle);
             invokeCandidateStateListeners(candidateBundle);
@@ -1183,7 +1183,7 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd
         synchronized (monitor) {
             while (true) {
                 int ackedNodes = 0;
-                for (NodeInfo node : cluster.getNodeInfo()) {
+                for (NodeInfo node : cluster.getNodeInfos()) {
                     if (node.getClusterStateVersionBundleAcknowledged() >= version) {
                         ++ackedNodes;
                     }
@@ -1206,7 +1206,7 @@ public class FleetController implements NodeStateOrHostInfoChangeHandler, NodeAd
         synchronized (monitor) {
             while (true) {
                 int distCount = 0, storCount = 0;
-                for (NodeInfo info : cluster.getNodeInfo()) {
+                for (NodeInfo info : cluster.getNodeInfos()) {
                     if (!info.isRpcAddressOutdated()) {
                         if (info.isDistributor()) ++distCount;
                         else ++storCount;
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java
index eb0368749f0..3ed03e94fda 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java
@@ -359,7 +359,7 @@ public class NodeStateChangeChecker {
         // This method verifies both storage nodes and distributors are up (or retired).
         // The complicated part is making a summary error message.
 
-        for (NodeInfo storageNodeInfo : clusterInfo.getStorageNodeInfo()) {
+        for (NodeInfo storageNodeInfo : clusterInfo.getStorageNodeInfos()) {
             State wantedState = storageNodeInfo.getUserWantedState().getState();
             if (wantedState != State.UP && wantedState != State.RETIRED) {
                 return Result.createDisallowed("Another storage node wants state " +
@@ -373,7 +373,7 @@ public class NodeStateChangeChecker {
             }
         }
 
-        for (NodeInfo distributorNodeInfo : clusterInfo.getDistributorNodeInfo()) {
+        for (NodeInfo distributorNodeInfo : clusterInfo.getDistributorNodeInfos()) {
             State wantedState = distributorNodeInfo.getUserWantedState().getState();
             if (wantedState != State.UP && wantedState != State.RETIRED) {
                 return Result.createDisallowed("Another distributor wants state " + wantedState.toString().toUpperCase() +
@@ -418,10 +418,10 @@ public class NodeStateChangeChecker {
      * @param clusterStateVersion the cluster state we expect distributors to have
      */
     private Result checkDistributors(Node node, int clusterStateVersion) {
-        if (clusterInfo.getDistributorNodeInfo().isEmpty()) {
+        if (clusterInfo.getDistributorNodeInfos().isEmpty()) {
             return Result.createDisallowed("Not aware of any distributors, probably not safe to upgrade?");
         }
-        for (DistributorNodeInfo distributorNodeInfo : clusterInfo.getDistributorNodeInfo()) {
+        for (DistributorNodeInfo distributorNodeInfo : clusterInfo.getDistributorNodeInfos()) {
             Integer distributorClusterStateVersion = distributorNodeInfo.getHostInfo().getClusterStateVersionOrNull();
             if (distributorClusterStateVersion == null) {
                 return Result.createDisallowed("Distributor node " + distributorNodeInfo.getNodeIndex()
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateGatherer.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateGatherer.java
index e3fe371c05e..cb22271b401 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateGatherer.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateGatherer.java
@@ -57,7 +57,7 @@ public class NodeStateGatherer {
     public boolean sendMessages(ContentCluster cluster, Communicator communicator, NodeStateOrHostInfoChangeHandler listener) {
         boolean sentAnyMessages = false;
         long currentTime = timer.getCurrentTimeInMillis();
-        for (NodeInfo info : cluster.getNodeInfo()) {
+        for (NodeInfo info : cluster.getNodeInfos()) {
             Long requestTime = info.getLatestNodeStateRequestTime();
 
             if (requestTime != null && (currentTime - requestTime < nodeStateRequestTimeoutMS)) continue; // pending request
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/StateChangeHandler.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/StateChangeHandler.java
index 46fafddfade..47b5b38edc8 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/StateChangeHandler.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/StateChangeHandler.java
@@ -246,7 +246,7 @@ public class StateChangeHandler {
         boolean triggeredAnyTimers = false;
         final long currentTime = timer.getCurrentTimeInMillis();
 
-        for(NodeInfo node : cluster.getNodeInfo()) {
+        for(NodeInfo node : cluster.getNodeInfos()) {
             triggeredAnyTimers |= handleTimeDependentOpsForNode(currentClusterState, nodeListener, currentTime, node);
         }
 
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java
index d061f7edbea..2359e4d8389 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/SystemStateBroadcaster.java
@@ -188,18 +188,18 @@ public class SystemStateBroadcaster {
     }
 
     private List<NodeInfo> resolveStateVersionSendSet(DatabaseHandler.DatabaseContext dbContext) {
-        return dbContext.getCluster().getNodeInfo().stream()
-                .filter(this::nodeNeedsClusterStateBundle)
-                .filter(node -> !newestStateBundleAlreadySentToNode(node))
-                .collect(Collectors.toList());
+        return dbContext.getCluster().getNodeInfos().stream()
+                        .filter(this::nodeNeedsClusterStateBundle)
+                        .filter(node -> !newestStateBundleAlreadySentToNode(node))
+                        .collect(Collectors.toList());
     }
 
     // Precondition: no nodes in the cluster need to receive the current cluster state version bundle
     private List<NodeInfo> resolveStateActivationSendSet(DatabaseHandler.DatabaseContext dbContext) {
-        return dbContext.getCluster().getNodeInfo().stream()
-                .filter(this::nodeNeedsClusterStateActivation)
-                .filter(node -> !newestStateActivationAlreadySentToNode(node))
-                .collect(Collectors.toList());
+        return dbContext.getCluster().getNodeInfos().stream()
+                        .filter(this::nodeNeedsClusterStateActivation)
+                        .filter(node -> !newestStateActivationAlreadySentToNode(node))
+                        .collect(Collectors.toList());
     }
 
     private boolean newestStateBundleAlreadySentToNode(NodeInfo node) {
@@ -222,9 +222,9 @@ public class SystemStateBroadcaster {
             return; // Nothing to do for the current state
         }
         final int currentStateVersion = clusterStateBundle.getVersion();
-        boolean anyDistributorsNeedStateBundle = dbContext.getCluster().getNodeInfo().stream()
-                .filter(NodeInfo::isDistributor)
-                .anyMatch(this::nodeNeedsClusterStateBundle);
+        boolean anyDistributorsNeedStateBundle = dbContext.getCluster().getNodeInfos().stream()
+                                                          .filter(NodeInfo::isDistributor)
+                                                          .anyMatch(this::nodeNeedsClusterStateBundle);
 
         if (!anyDistributorsNeedStateBundle && (currentStateVersion > lastStateVersionBundleAcked)) {
             markCurrentClusterStateBundleAsReceivedByAllDistributors();
@@ -243,9 +243,9 @@ public class SystemStateBroadcaster {
             return;
         }
 
-        boolean anyDistributorsNeedActivation = dbContext.getCluster().getNodeInfo().stream()
-                .filter(NodeInfo::isDistributor)
-                .anyMatch(this::nodeNeedsClusterStateActivation);
+        boolean anyDistributorsNeedActivation = dbContext.getCluster().getNodeInfos().stream()
+                                                         .filter(NodeInfo::isDistributor)
+                                                         .anyMatch(this::nodeNeedsClusterStateActivation);
 
         if (!anyDistributorsNeedActivation && (currentStateVersion > lastClusterStateVersionConverged)) {
             markCurrentClusterStateAsConverged(database, dbContext, fleetController);
@@ -352,7 +352,7 @@ public class SystemStateBroadcaster {
 
     private static ClusterState buildModifiedClusterState(ClusterState sourceState, DatabaseHandler.DatabaseContext dbContext) {
         ClusterState newState = sourceState.clone();
-        for (NodeInfo n : dbContext.getCluster().getNodeInfo()) {
+        for (NodeInfo n : dbContext.getCluster().getNodeInfos()) {
             NodeState ns = newState.getNodeState(n.getNode());
             if (!n.isDistributor() && ns.getStartTimestamp() == 0) {
                 ns.setStartTimestamp(n.getStartTimestamp());
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java
index 0c6c773a9bc..6db3c640a61 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/database/DatabaseHandler.java
@@ -429,7 +429,7 @@ public class DatabaseHandler {
     public void saveWantedStates(DatabaseContext databaseContext) {
         fleetControllerContext.log(logger, Level.FINE, () -> "Checking whether wanted states have changed compared to zookeeper version.");
         Map<Node, NodeState> wantedStates = new TreeMap<>();
-        for (NodeInfo info : databaseContext.getCluster().getNodeInfo()) {
+        for (NodeInfo info : databaseContext.getCluster().getNodeInfos()) {
             if (!info.getUserWantedState().equals(new NodeState(info.getNode().getType(), State.UP))) {
                 wantedStates.put(info.getNode(), info.getUserWantedState());
             }
@@ -477,7 +477,7 @@ public class DatabaseHandler {
         }
 
         // Remove wanted state from any node having a wanted state set that is no longer valid
-        for (NodeInfo info : databaseContext.getCluster().getNodeInfo()) {
+        for (NodeInfo info : databaseContext.getCluster().getNodeInfos()) {
             NodeState wantedState = wantedStates.get(info.getNode());
             if (wantedState == null && !info.getUserWantedState().equals(new NodeState(info.getNode().getType(), State.UP))) {
                 info.setWantedState(null);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RpcServer.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RpcServer.java
index 65c8a9df28e..60cd3c06893 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RpcServer.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/RpcServer.java
@@ -234,7 +234,7 @@ public class RpcServer {
                     log.log(Level.FINE, "Resolving RPC getNodeList request");
                     List<String> slobrok = new ArrayList<String>();
                     List<String> rpc = new ArrayList<String>();
-                    for(NodeInfo node : cluster.getNodeInfo()) {
+                    for(NodeInfo node : cluster.getNodeInfos()) {
                         String s1 = node.getSlobrokAddress();
                         String s2 = node.getRpcAddress();
                         assert(s1 != null);
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/SlobrokClient.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/SlobrokClient.java
index 7487f9546b7..589e9b25e54 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/SlobrokClient.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/rpc/SlobrokClient.java
@@ -149,7 +149,7 @@ public class SlobrokClient implements NodeLookup {
             }
         }
         cluster.setSlobrokGenerationCount(mirrorVersion);
-        for (NodeInfo nodeInfo : cluster.getNodeInfo()) {
+        for (NodeInfo nodeInfo : cluster.getNodeInfos()) {
             if (slobrokNodes.containsKey(nodeInfo.getNode()) && nodeInfo.isRpcAddressOutdated()) {
                 context.log(log,
                             Level.WARNING,
@@ -174,7 +174,7 @@ public class SlobrokClient implements NodeLookup {
             List<SlobrokData> alteredRpcAddress,
             List<NodeInfo> returningRpcAddressNodeInfos)
     {
-        Iterator<NodeInfo> oldIt = oldCluster.getNodeInfo().iterator();
+        Iterator<NodeInfo> oldIt = oldCluster.getNodeInfos().iterator();
         Iterator<SlobrokData> newIt = slobrokNodes.values().iterator();
         NodeInfo oldNext = null;
         SlobrokData newNext = null;