Use latest candidate cluster state when comparing against reported node states

Using just the versioned cluster state instead can cause the code to
erroneously believe that it is seeing repeated reported state changes
for the first time. This happens when the diffs in the reported node
states are not in and by themselves enough to trigger a new cluster state
version containing the changes.

This can in turn spam the logs and event buffers until a new cluster state
has been versioned.

1 files changed, 6 insertions, 0 deletions

diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateVersionTrackerTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateVersionTrackerTest.java
index 72f8c9fb8b7..db66c4c9046 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateVersionTrackerTest.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateVersionTrackerTest.java
@@ -133,6 +133,12 @@ public class StateVersionTrackerTest {
     }
 
     @Test
+    public void init_progress_change_not_counted_as_changed_state() {
+        assertFalse(stateChangedBetween("distributor:2 storage:2 .0.s:i .0.i:0.5",
+                                        "distributor:2 storage:2 .0.s:i .0.i:0.6"));
+    }
+
+    @Test
     public void lowest_observed_distribution_bit_is_initially_16() {
         final StateVersionTracker versionTracker = createWithMockedMetrics();
         assertThat(versionTracker.getLowestObservedDistributionBits(), equalTo(16));