diff options
| author | Harald Musum <musum@yahooinc.com> | 2023-07-17 13:36:08 +0200 |
|---|---|---|
| committer | Harald Musum <musum@yahooinc.com> | 2023-07-17 13:36:08 +0200 |
| commit | 4de39b50afecc59d1e7cc05b658200979016c5ef (patch) | |
| tree | 0bfb46e1d036c4d345cc32631e525eee78f4fb87 /clustercontroller-core | |
| parent | f11dec52ee0df308f017e320c0bf7fc9198bf112 (diff) | |
Fix minor issues after code reviews
Diffstat (limited to 'clustercontroller-core')
2 files changed, 1 insertions, 3 deletions
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java index c81f01bd9aa..01d9e73c7bc 100644 --- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java +++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeChecker.java @@ -157,7 +157,7 @@ public class NodeStateChangeChecker { return result; if (isGroupedSetup()) { - if (maxNumberOfGroupsAllowedToBeDown == - 1) { + if (maxNumberOfGroupsAllowedToBeDown == -1) { result = checkIfAnotherNodeInAnotherGroupHasWantedState(nodeInfo); if (result.notAllowed()) return result; diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeCheckerTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeCheckerTest.java index 2174a206d4a..9cb589636da 100644 --- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeCheckerTest.java +++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/NodeStateChangeCheckerTest.java @@ -216,8 +216,6 @@ public class NodeStateChangeCheckerTest { @Test void testMaintenanceAllowedFor2Of4Groups8Nodes() { - // LogSetup.initVespaLogging("foo"); - int maxNumberOfGroupsAllowedToBeDown = 2; // 4 groups with 2 nodes in each group var cluster = createCluster(8, 4, maxNumberOfGroupsAllowedToBeDown); |