summaryrefslogtreecommitdiffstats
path: root/clustercontroller-core
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2022-09-20 10:42:13 +0200
committerHarald Musum <musum@yahooinc.com>2022-09-20 10:42:13 +0200
commitbd7b4d77d57c6d40d0da9387a89bdeffefaacd98 (patch)
treed9401a25343aafba32cd6d4c0fa9323c4c42c9b7 /clustercontroller-core
parent3dd0ecf0fbc1ebe1ef6a896ac328bba0dd7743a4 (diff)
configuredBucketSpaces never changes, make it final
Diffstat (limited to 'clustercontroller-core')
-rw-r--r--clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java6
1 files changed, 2 insertions, 4 deletions
diff --git a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
index 53dc71b2a90..f2f9e52262b 100644
--- a/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
+++ b/clustercontroller-core/src/main/java/com/yahoo/vespa/clustercontroller/core/FleetController.java
@@ -32,7 +32,6 @@ import java.time.Instant;
import java.util.ArrayDeque;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Collections;
import java.util.HashSet;
import java.util.LinkedList;
import java.util.List;
@@ -99,7 +98,7 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
// Legacy behavior is an empty set of explicitly configured bucket spaces, which means that
// only a baseline cluster state will be sent from the controller and no per-space state
// deriving is done.
- private Set<String> configuredBucketSpaces = Collections.emptySet();
+ private final Set<String> configuredBucketSpaces = Set.of(FixedBucketSpaces.defaultSpace(), FixedBucketSpaces.globalSpace());
public FleetController(FleetControllerContext context,
Timer timer,
@@ -487,7 +486,6 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
cluster.setSlobrokGenerationCount(0);
}
- configuredBucketSpaces = Set.of(FixedBucketSpaces.defaultSpace(), FixedBucketSpaces.globalSpace());
stateVersionTracker.setMinMergeCompletionRatio(options.minMergeCompletionRatio());
communicator.propagateOptions(options);
@@ -625,7 +623,7 @@ public class FleetController implements NodeListener, SlobrokListener, SystemSta
if (tickStopTime >= tickStartTime) {
metricUpdater.addTickTime(tickStopTime - tickStartTime, didWork);
}
- // Always sleep some to use avoid using too much CPU and avoid starving waiting threads
+ // Always sleep some to avoid using too much CPU and avoid starving waiting threads
monitor.wait(didWork || waitingForCycle ? 1 : options.cycleWaitTime());
if ( ! isRunning()) { return; }
tickStartTime = timer.getCurrentTimeInMillis();