summaryrefslogtreecommitdiffstats
path: root/clustercontroller-core
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2022-08-18 09:40:54 +0200
committerHarald Musum <musum@yahooinc.com>2022-08-18 09:40:54 +0200
commit935fa8d17872cc6c35b65cc44ed6c6985ab3f448 (patch)
treee5adf5bb7ca4f2621de059895ba92fe014f771ba /clustercontroller-core
parenta5f1486bdae53d4f1f22023907e7974eae9c1704 (diff)
Avoid duplicating code
Diffstat (limited to 'clustercontroller-core')
-rw-r--r--clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java14
1 files changed, 5 insertions, 9 deletions
diff --git a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java
index c39a5c52836..91a348ab1ba 100644
--- a/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java
+++ b/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/FleetControllerTest.java
@@ -176,12 +176,9 @@ public abstract class FleetControllerTest implements Waiter {
}
protected void setUpFleetController(boolean useFakeTimer, FleetControllerOptions options) throws Exception {
- if (slobrok == null) setUpSystem(options);
- if (fleetController == null) {
- fleetController = createFleetController(useFakeTimer, options);
- } else {
- throw new Exception("called setUpFleetcontroller but it was already setup");
- }
+ if (slobrok == null)
+ setUpSystem(options);
+ startFleetController(useFakeTimer);
}
void stopFleetController() throws Exception {
@@ -192,11 +189,10 @@ public abstract class FleetControllerTest implements Waiter {
}
void startFleetController(boolean useFakeTimer) throws Exception {
- if (fleetController == null) {
+ if (fleetController == null)
fleetController = createFleetController(useFakeTimer, options);
- } else {
+ else
log.log(Level.WARNING, "already started fleetcontroller, not starting another");
- }
}
protected void setUpVdsNodes(boolean useFakeTimer, DummyVdsNodeOptions options) throws Exception {