summaryrefslogtreecommitdiffstats
path: root/clustercontroller-reindexer/src
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2022-02-11 09:15:33 +0100
committerHenning Baldersheim <balder@yahoo-inc.com>2022-02-11 09:15:33 +0100
commitcd5530f09b8c21c80366481544bdb6529f9f29eb (patch)
treefa3dc0bca6c9d76a10e1b2bfa924805d466cd6af /clustercontroller-reindexer/src
parentd7a92cc0fc9bca05b7a028cfa971183a4fddea8f (diff)
Require shutdown to complete faster.
Diffstat (limited to 'clustercontroller-reindexer/src')
-rw-r--r--clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingMaintainer.java14
1 files changed, 10 insertions, 4 deletions
diff --git a/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingMaintainer.java b/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingMaintainer.java
index e784f070188..a9642c591ea 100644
--- a/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingMaintainer.java
+++ b/clustercontroller-reindexer/src/main/java/ai/vespa/reindexing/ReindexingMaintainer.java
@@ -100,17 +100,23 @@ public class ReindexingMaintainer extends AbstractComponent {
reindexer.shutdown();
executor.shutdown();
- if ( ! executor.awaitTermination(45, TimeUnit.SECONDS))
+
+ executor.awaitTermination(5, TimeUnit.SECONDS); // Give it 5s to complete gracefully.
+
+ curator.close(); // Close the underlying curator independently to force shutdown
+
+ if ( !executor.isShutdown() && ! executor.awaitTermination(5, TimeUnit.SECONDS))
log.log(WARNING, "Failed to shut down reindexing within timeout");
}
catch (InterruptedException e) {
log.log(WARNING, "Interrupted while waiting for reindexing to shut down");
Thread.currentThread().interrupt();
}
- if ( ! executor.isShutdown())
- executor.shutdownNow();
+ if ( ! executor.isShutdown()) {
+ List<Runnable> remaining = executor.shutdownNow();
+ log.log(WARNING, "Number of tasks remaining at hard shutdown: " + remaining.size());
+ }
- curator.close();
}
static List<Trigger> parseReady(ReindexingConfig.Clusters cluster, DocumentTypeManager manager) {