aboutsummaryrefslogtreecommitdiffstats
path: root/config-application-package/src/test/java/com/yahoo
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2022-04-27 09:44:54 +0200
committerHarald Musum <musum@yahooinc.com>2022-04-27 09:44:54 +0200
commit90402e33fe73f74e38f77d6a1ddc5b892aaf03f2 (patch)
treeae9ff8d0fc6568ec1eaa34c667077e860dcffdc0 /config-application-package/src/test/java/com/yahoo
parente45cd30a0cf9e99be02af029dbb5c8517ba8ce4b (diff)
Validate file extension for files in application package
Start validating file extension for files application package subdirectories, only a subset of subdirectories handled for now
Diffstat (limited to 'config-application-package/src/test/java/com/yahoo')
-rw-r--r--config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java23
1 files changed, 22 insertions, 1 deletions
diff --git a/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java b/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java
index fd5437c27de..bea7efb40f4 100644
--- a/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java
+++ b/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java
@@ -105,7 +105,7 @@ public class FilesApplicationPackageTest {
}
@Test
- public void testLegacyOverrides() throws IOException {
+ public void testLegacyOverrides() {
File appDir = new File("src/test/resources/app-legacy-overrides");
ApplicationPackage app = FilesApplicationPackage.fromFile(appDir);
var overrides = app.legacyOverrides();
@@ -143,4 +143,25 @@ public class FilesApplicationPackageTest {
.getMessage());
}
+ @Test
+ public void testValidFileExtensions() {
+ File appDir = new File("src/test/resources/app-with-deployment");;
+ FilesApplicationPackage app = FilesApplicationPackage.fromFile(appDir);
+ app.validateFileExtensions(true);
+ }
+
+ @Test
+ public void testInvalidFileExtensions() {
+ File appDir = new File("src/test/resources/app-with-invalid-files-in-subdir");;
+ FilesApplicationPackage app = FilesApplicationPackage.fromFile(appDir);
+ try {
+ app.validateFileExtensions(true);
+ fail("expected an exception");
+ } catch (IllegalArgumentException e) {
+ assertEquals("File in application package with unknown suffix: search/query-profiles/file-with-invalid.extension " +
+ "Please delete or move file to another directory.",
+ e.getMessage());
+ }
+ }
+
}