diff options
author | Harald Musum <musum@yahooinc.com> | 2023-07-06 09:29:57 +0200 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2023-07-06 09:29:57 +0200 |
commit | ea27a98d79874b11a316a34e670d04dccfa31528 (patch) | |
tree | 9efd251383978af7b37d04e63854e7ee15ed4ce2 /config-application-package/src | |
parent | 59363d1fadbc8fc53a1f81f1427f50c0019a8f10 (diff) |
Use different exception message if services.xml is missing
Diffstat (limited to 'config-application-package/src')
2 files changed, 7 insertions, 8 deletions
diff --git a/config-application-package/src/main/java/com/yahoo/config/model/application/provider/FilesApplicationPackage.java b/config-application-package/src/main/java/com/yahoo/config/model/application/provider/FilesApplicationPackage.java index f5ad1dce4e7..dd8bb7f78e2 100644 --- a/config-application-package/src/main/java/com/yahoo/config/model/application/provider/FilesApplicationPackage.java +++ b/config-application-package/src/main/java/com/yahoo/config/model/application/provider/FilesApplicationPackage.java @@ -625,7 +625,9 @@ public class FilesApplicationPackage extends AbstractApplicationPackage { private File validateServicesFile() throws IOException { File servicesFile = getServicesFile(); - if ( ! servicesFile.exists() || IOUtils.readFile(servicesFile).isEmpty()) + if ( ! servicesFile.exists()) + throw new IllegalArgumentException(SERVICES + " does not exist in application package"); + if (IOUtils.readFile(servicesFile).isEmpty()) throw new IllegalArgumentException(SERVICES + " in application package is empty"); return servicesFile; } diff --git a/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java b/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java index 4742d275918..495a03fa0b2 100644 --- a/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java +++ b/config-application-package/src/test/java/com/yahoo/config/model/application/provider/FilesApplicationPackageTest.java @@ -122,17 +122,14 @@ public class FilesApplicationPackageTest { } @Test - public void failOnEmptyServicesXml() throws IOException { + public void failOnMissingServicesXml() throws IOException { File appDir = temporaryFolder.newFolder(); IOUtils.copyDirectory(new File("src/test/resources/multienvapp"), appDir); Files.delete(new File(appDir, "services.xml").toPath()); FilesApplicationPackage app = FilesApplicationPackage.fromFile(appDir); - try { - app.preprocess(new Zone(Environment.dev, RegionName.defaultName()), new BaseDeployLogger()); - fail(); - } catch (IllegalArgumentException e) { - assertTrue(e.getMessage().contains("services.xml in application package is empty")); - } + var exception = assertThrows(IllegalArgumentException.class, + () -> app.preprocess(new Zone(Environment.dev, RegionName.defaultName()), new BaseDeployLogger())); + assertEquals("services.xml does not exist in application package", exception.getMessage()); } @Test |