aboutsummaryrefslogtreecommitdiffstats
path: root/config-model-api/src/main/java
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2020-11-20 14:10:29 +0100
committerJon Marius Venstad <venstad@gmail.com>2020-11-20 14:10:29 +0100
commite6f880fec472614dc77b07a25799346bdec5e6ff (patch)
treeed05ea99b5546c7ab136d9ae14680c2d4deb42aa /config-model-api/src/main/java
parent28ebee04d75871c2e268bfd8375b02759ca52d4e (diff)
Remove "allowed" from config change actions (+ wiring) — allowed if not thrown
Diffstat (limited to 'config-model-api/src/main/java')
-rw-r--r--config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeAction.java7
-rw-r--r--config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeRestartAction.java4
2 files changed, 1 insertions, 10 deletions
diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeAction.java b/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeAction.java
index 70a54918216..87a150a6c3c 100644
--- a/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeAction.java
+++ b/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeAction.java
@@ -39,16 +39,11 @@ public interface ConfigChangeAction {
/** Returns the list of services where the action must be performed */
List<ServiceInfo> getServices();
- /** Returns whether this change should be allowed. */
- // TODO jonmv: remove in 2021.
- boolean allowed();
-
/** When this is non-empty, validation may fail unless this validation id is allowed by validation overrides. */
default Optional<ValidationId> validationId() { return Optional.empty(); }
/** The id of the cluster that needs this action applied */
- // TODO: Remove this default implementation after October 2020
- default ClusterSpec.Id clusterId() { return null; }
+ ClusterSpec.Id clusterId();
/** Returns whether this change should be ignored for internal redeploy */
default boolean ignoreForInternalRedeploy() {
diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeRestartAction.java b/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeRestartAction.java
index f178180b6e0..c13399a42f5 100644
--- a/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeRestartAction.java
+++ b/config-model-api/src/main/java/com/yahoo/config/model/api/ConfigChangeRestartAction.java
@@ -11,8 +11,4 @@ public interface ConfigChangeRestartAction extends ConfigChangeAction {
@Override
default Type getType() { return Type.RESTART; }
- /** Restarts are handled automatically so they are allowed */
- @Override
- default boolean allowed() { return true; }
-
}