Revert "Revert "Enable ABI checking on modules with public APIs""

This reverts commit cd470d8ac8a58c943748f028a37d864507628e99.

2 files changed, 456 insertions, 0 deletions

diff --git a/config-model-api/abi-spec.json b/config-model-api/abi-spec.json
new file mode 100644
index 00000000000..d302ee58855
--- /dev/null
+++ b/config-model-api/abi-spec.json
@@ -0,0 +1,452 @@
+{
+  "com.yahoo.config.application.api.ApplicationFile$MetaData": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>()",
+      "public void <init>(java.lang.String, java.lang.String)",
+      "public java.lang.String getStatus()",
+      "public java.lang.String getMd5()"
+    ],
+    "fields": [
+      "public java.lang.String status",
+      "public java.lang.String md5"
+    ]
+  },
+  "com.yahoo.config.application.api.ApplicationFile$PathFilter": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "interface",
+      "abstract"
+    ],
+    "methods": [
+      "public abstract boolean accept(com.yahoo.path.Path)"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.ApplicationFile": {
+    "superClass": "java.lang.Object",
+    "interfaces": [
+      "java.lang.Comparable"
+    ],
+    "attributes": [
+      "public",
+      "abstract"
+    ],
+    "methods": [
+      "protected void <init>(com.yahoo.path.Path)",
+      "public abstract boolean isDirectory()",
+      "public abstract boolean exists()",
+      "public abstract java.io.Reader createReader()",
+      "public abstract java.io.InputStream createInputStream()",
+      "public abstract com.yahoo.config.application.api.ApplicationFile createDirectory()",
+      "public abstract com.yahoo.config.application.api.ApplicationFile writeFile(java.io.Reader)",
+      "public abstract com.yahoo.config.application.api.ApplicationFile appendFile(java.lang.String)",
+      "public java.util.List listFiles()",
+      "public abstract java.util.List listFiles(com.yahoo.config.application.api.ApplicationFile$PathFilter)",
+      "public java.util.List listFiles(boolean)",
+      "public abstract com.yahoo.config.application.api.ApplicationFile delete()",
+      "public com.yahoo.path.Path getPath()",
+      "public java.lang.String toString()",
+      "public boolean equals(java.lang.Object)",
+      "protected com.yahoo.path.Path getMetaPath()",
+      "public abstract com.yahoo.config.application.api.ApplicationFile$MetaData getMetaData()"
+    ],
+    "fields": [
+      "public static final java.lang.String ContentStatusNew",
+      "public static final java.lang.String ContentStatusChanged",
+      "public static final java.lang.String ContentStatusDeleted",
+      "protected final com.yahoo.path.Path path"
+    ]
+  },
+  "com.yahoo.config.application.api.ApplicationMetaData": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.io.File, java.lang.String, java.lang.String, java.lang.Long, boolean, java.lang.String, java.lang.Long, long)",
+      "public void <init>(java.lang.String, java.lang.String, java.lang.Long, boolean, java.lang.String, java.lang.String, java.lang.Long, long)",
+      "public java.lang.String getApplicationName()",
+      "public java.lang.String getDeployedByUser()",
+      "public java.lang.String getDeployPath()",
+      "public java.lang.Long getDeployTimestamp()",
+      "public java.lang.Long getGeneration()",
+      "public boolean isInternalRedeploy()",
+      "public java.lang.String getCheckSum()",
+      "public long getPreviousActiveGeneration()",
+      "public java.lang.String toString()",
+      "public static com.yahoo.config.application.api.ApplicationMetaData fromJsonString(java.lang.String)",
+      "public com.yahoo.slime.Slime getSlime()",
+      "public java.lang.String asJsonString()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.ApplicationPackage": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "interface",
+      "abstract"
+    ],
+    "methods": [
+      "public abstract java.lang.String getApplicationName()",
+      "public abstract java.io.Reader getServices()",
+      "public abstract java.io.Reader getHosts()",
+      "public java.util.List getUserIncludeDirs()",
+      "public void validateIncludeDir(java.lang.String)",
+      "public abstract java.util.Collection searchDefinitionContents()",
+      "public abstract java.util.Map getAllExistingConfigDefs()",
+      "public abstract java.util.List getFiles(com.yahoo.path.Path, java.lang.String, boolean)",
+      "public java.util.List getFiles(com.yahoo.path.Path, java.lang.String)",
+      "public java.util.Optional getMajorVersion()",
+      "public abstract com.yahoo.config.application.api.ApplicationFile getFile(com.yahoo.path.Path)",
+      "public java.util.List getQueryProfileFiles()",
+      "public java.util.List getQueryProfileTypeFiles()",
+      "public java.util.List getPageTemplateFiles()",
+      "public abstract java.lang.String getHostSource()",
+      "public abstract java.lang.String getServicesSource()",
+      "public abstract java.util.Optional getDeployment()",
+      "public abstract java.util.Optional getValidationOverrides()",
+      "public java.util.List getComponentsInfo(com.yahoo.config.provision.Version)",
+      "public java.util.List getComponentsInfo(com.yahoo.component.Version)",
+      "public abstract java.io.Reader getRankingExpression(java.lang.String)",
+      "public static java.util.Map getBundleSdFiles(java.lang.String, java.util.jar.JarFile)",
+      "public static java.lang.String getFileName(java.util.jar.JarEntry)",
+      "public abstract com.yahoo.config.application.api.ApplicationMetaData getMetaData()",
+      "public abstract java.io.File getFileReference(com.yahoo.path.Path)",
+      "public void validateXML()",
+      "public void validateXML(java.util.Optional)",
+      "public void validateXMLFor(java.util.Optional)",
+      "public void writeMetaData()",
+      "public java.util.Map getProvisionInfoMap()",
+      "public java.util.Optional getAllocatedHosts()",
+      "public java.util.Map getFileRegistryMap()",
+      "public java.util.Map getFileRegistries()",
+      "public abstract java.util.Collection getSearchDefinitions()",
+      "public com.yahoo.config.application.api.ApplicationPackage preprocess(com.yahoo.config.provision.Zone, com.yahoo.config.application.api.DeployLogger)"
+    ],
+    "fields": [
+      "public static final java.lang.String HOSTS",
+      "public static final java.lang.String SERVICES",
+      "public static final com.yahoo.path.Path SEARCH_DEFINITIONS_DIR",
+      "public static final java.lang.String COMPONENT_DIR",
+      "public static final java.lang.String SEARCHCHAINS_DIR",
+      "public static final java.lang.String DOCPROCCHAINS_DIR",
+      "public static final java.lang.String PROCESSORCHAINS_DIR",
+      "public static final java.lang.String ROUTINGTABLES_DIR",
+      "public static final com.yahoo.path.Path MODELS_DIR",
+      "public static final com.yahoo.path.Path MODELS_GENERATED_DIR",
+      "public static final com.yahoo.path.Path MODELS_GENERATED_REPLICATED_DIR",
+      "public static final java.lang.String CONFIG_DEFINITIONS_DIR",
+      "public static final com.yahoo.path.Path QUERY_PROFILES_DIR",
+      "public static final com.yahoo.path.Path QUERY_PROFILE_TYPES_DIR",
+      "public static final com.yahoo.path.Path PAGE_TEMPLATES_DIR",
+      "public static final com.yahoo.path.Path RULES_DIR",
+      "public static final com.yahoo.path.Path DEPLOYMENT_FILE",
+      "public static final com.yahoo.path.Path VALIDATION_OVERRIDES",
+      "public static final java.lang.String SD_NAME_SUFFIX",
+      "public static final java.lang.String RANKEXPRESSION_NAME_SUFFIX",
+      "public static final java.lang.String RULES_NAME_SUFFIX",
+      "public static final java.lang.String EXT_DIR",
+      "public static final java.lang.String PERMANENT_SERVICES"
+    ]
+  },
+  "com.yahoo.config.application.api.ComponentInfo": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.lang.String)",
+      "public java.lang.String getPathRelativeToAppDir()",
+      "public java.lang.String toString()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeployLogger": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "interface",
+      "abstract"
+    ],
+    "methods": [
+      "public abstract void log(java.util.logging.Level, java.lang.String)"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeploymentSpec$ChangeBlocker": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(boolean, boolean, com.yahoo.config.application.api.TimeWindow)",
+      "public boolean blocksRevisions()",
+      "public boolean blocksVersions()",
+      "public com.yahoo.config.application.api.TimeWindow window()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeploymentSpec$DeclaredZone": {
+    "superClass": "com.yahoo.config.application.api.DeploymentSpec$Step",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(com.yahoo.config.provision.Environment)",
+      "public void <init>(com.yahoo.config.provision.Environment, java.util.Optional, boolean)",
+      "public void <init>(com.yahoo.config.provision.Environment, java.util.Optional, boolean, java.util.Optional)",
+      "public com.yahoo.config.provision.Environment environment()",
+      "public java.util.Optional region()",
+      "public boolean active()",
+      "public java.util.Optional athenzService()",
+      "public java.util.List zones()",
+      "public boolean deploysTo(com.yahoo.config.provision.Environment, java.util.Optional)",
+      "public int hashCode()",
+      "public boolean equals(java.lang.Object)",
+      "public java.lang.String toString()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeploymentSpec$Delay": {
+    "superClass": "com.yahoo.config.application.api.DeploymentSpec$Step",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.time.Duration)",
+      "public java.time.Duration duration()",
+      "public boolean deploysTo(com.yahoo.config.provision.Environment, java.util.Optional)"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeploymentSpec$ParallelZones": {
+    "superClass": "com.yahoo.config.application.api.DeploymentSpec$Step",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.util.List)",
+      "public java.util.List zones()",
+      "public boolean deploysTo(com.yahoo.config.provision.Environment, java.util.Optional)",
+      "public boolean equals(java.lang.Object)",
+      "public int hashCode()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeploymentSpec$Step": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "abstract"
+    ],
+    "methods": [
+      "public void <init>()",
+      "public final boolean deploysTo(com.yahoo.config.provision.Environment)",
+      "public abstract boolean deploysTo(com.yahoo.config.provision.Environment, java.util.Optional)",
+      "public java.util.List zones()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy": {
+    "superClass": "java.lang.Enum",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "final",
+      "enum"
+    ],
+    "methods": [
+      "public static com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy[] values()",
+      "public static com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy valueOf(java.lang.String)"
+    ],
+    "fields": [
+      "public static final enum com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy canary",
+      "public static final enum com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy defaultPolicy",
+      "public static final enum com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy conservative"
+    ]
+  },
+  "com.yahoo.config.application.api.DeploymentSpec": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.util.Optional, com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy, java.util.List, java.util.List)",
+      "public void <init>(java.util.Optional, com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy, java.util.Optional, java.util.List, java.util.List)",
+      "public void <init>(java.util.Optional, com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy, java.util.Optional, java.util.List, java.util.List, java.lang.String, java.util.Optional, java.util.Optional)",
+      "public java.util.Optional globalServiceId()",
+      "public com.yahoo.config.application.api.DeploymentSpec$UpgradePolicy upgradePolicy()",
+      "public java.util.Optional majorVersion()",
+      "public boolean canUpgradeAt(java.time.Instant)",
+      "public boolean canChangeRevisionAt(java.time.Instant)",
+      "public java.util.List changeBlocker()",
+      "public java.util.List steps()",
+      "public java.util.List zones()",
+      "public java.lang.String xmlForm()",
+      "public boolean includes(com.yahoo.config.provision.Environment, java.util.Optional)",
+      "public static com.yahoo.config.application.api.DeploymentSpec fromXml(java.io.Reader)",
+      "public static com.yahoo.config.application.api.DeploymentSpec fromXml(java.lang.String)",
+      "public static com.yahoo.config.application.api.DeploymentSpec fromXml(java.lang.String, boolean)",
+      "public static java.lang.String toMessageString(java.lang.Throwable)",
+      "public java.util.Optional athenzDomain()",
+      "public java.util.Optional athenzService(com.yahoo.config.provision.Environment, com.yahoo.config.provision.RegionName)",
+      "public static void main(java.lang.String[])"
+    ],
+    "fields": [
+      "public static final com.yahoo.config.application.api.DeploymentSpec empty"
+    ]
+  },
+  "com.yahoo.config.application.api.FileRegistry$Entry": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.lang.String, com.yahoo.config.FileReference)"
+    ],
+    "fields": [
+      "public final java.lang.String relativePath",
+      "public final com.yahoo.config.FileReference reference"
+    ]
+  },
+  "com.yahoo.config.application.api.FileRegistry": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "interface",
+      "abstract"
+    ],
+    "methods": [
+      "public abstract com.yahoo.config.FileReference addFile(java.lang.String)",
+      "public abstract com.yahoo.config.FileReference addUri(java.lang.String)",
+      "public abstract java.lang.String fileSourceHost()",
+      "public abstract java.util.List export()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.TimeWindow": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public java.util.List days()",
+      "public java.util.List hours()",
+      "public java.time.ZoneId zone()",
+      "public boolean includes(java.time.Instant)",
+      "public java.lang.String toString()",
+      "public static com.yahoo.config.application.api.TimeWindow from(java.lang.String, java.lang.String, java.lang.String)"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.UnparsedConfigDefinition": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "interface",
+      "abstract"
+    ],
+    "methods": [
+      "public abstract com.yahoo.vespa.config.ConfigDefinition parse()",
+      "public abstract java.lang.String getUnparsedContent()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.ValidationId": {
+    "superClass": "java.lang.Enum",
+    "interfaces": [],
+    "attributes": [
+      "public",
+      "final",
+      "enum"
+    ],
+    "methods": [
+      "public static com.yahoo.config.application.api.ValidationId[] values()",
+      "public static com.yahoo.config.application.api.ValidationId valueOf(java.lang.String)",
+      "public java.lang.String value()",
+      "public java.lang.String toString()",
+      "public static java.util.Optional from(java.lang.String)"
+    ],
+    "fields": [
+      "public static final enum com.yahoo.config.application.api.ValidationId indexingChange",
+      "public static final enum com.yahoo.config.application.api.ValidationId indexModeChange",
+      "public static final enum com.yahoo.config.application.api.ValidationId fieldTypeChange",
+      "public static final enum com.yahoo.config.application.api.ValidationId clusterSizeReduction",
+      "public static final enum com.yahoo.config.application.api.ValidationId contentTypeRemoval",
+      "public static final enum com.yahoo.config.application.api.ValidationId contentClusterRemoval",
+      "public static final enum com.yahoo.config.application.api.ValidationId deploymentRemoval",
+      "public static final enum com.yahoo.config.application.api.ValidationId skipAutomaticTenantUpgradeTests",
+      "public static final enum com.yahoo.config.application.api.ValidationId globalDocumentChange",
+      "public static final enum com.yahoo.config.application.api.ValidationId configModelVersionMismatch",
+      "public static final enum com.yahoo.config.application.api.ValidationId skipOldConfigModels",
+      "public static final enum com.yahoo.config.application.api.ValidationId forceAutomaticTenantUpgradeTests"
+    ]
+  },
+  "com.yahoo.config.application.api.ValidationOverrides$Allow": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(com.yahoo.config.application.api.ValidationId, java.time.Instant)",
+      "public boolean allows(com.yahoo.config.application.api.ValidationId, java.time.Instant)",
+      "public java.lang.String toString()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.ValidationOverrides$ValidationException": {
+    "superClass": "java.lang.IllegalArgumentException",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public com.yahoo.config.application.api.ValidationId validationId()",
+      "public java.lang.String getMessage()"
+    ],
+    "fields": []
+  },
+  "com.yahoo.config.application.api.ValidationOverrides": {
+    "superClass": "java.lang.Object",
+    "interfaces": [],
+    "attributes": [
+      "public"
+    ],
+    "methods": [
+      "public void <init>(java.util.List)",
+      "public void invalid(com.yahoo.config.application.api.ValidationId, java.lang.String, java.time.Instant)",
+      "public boolean allows(java.lang.String, java.time.Instant)",
+      "public boolean allows(com.yahoo.config.application.api.ValidationId, java.time.Instant)",
+      "public static java.lang.String toAllowMessage(com.yahoo.config.application.api.ValidationId)",
+      "public java.lang.String xmlForm()",
+      "public static com.yahoo.config.application.api.ValidationOverrides fromXml(java.io.Reader)",
+      "public static com.yahoo.config.application.api.ValidationOverrides fromXml(java.lang.String)"
+    ],
+    "fields": [
+      "public static final com.yahoo.config.application.api.ValidationOverrides empty"
+    ]
+  }
+}
\ No newline at end of file
diff --git a/config-model-api/pom.xml b/config-model-api/pom.xml
index 109093beda9..21c3b6f2752 100644
--- a/config-model-api/pom.xml
+++ b/config-model-api/pom.xml
@@ -109,6 +109,10 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>com.yahoo.vespa</groupId>
+        <artifactId>abi-check-plugin</artifactId>
+      </plugin>
     </plugins>
   </build>
 </project>