Setting attribute on a field that has struct or map sub-type(s) is not supported.

Fail instead of silently ignoring it as that makes the user believe it should work.

1 files changed, 21 insertions, 0 deletions

diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/document/SDField.java b/config-model/src/main/java/com/yahoo/searchdefinition/document/SDField.java
index 8b523211471..c4e0f4cafef 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/document/SDField.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/document/SDField.java
@@ -463,12 +463,33 @@ public class SDField extends Field implements TypedKey, FieldOperationContainer,
                     }
                 }
             }.visit(indexingScript);
+        } else {
+            if (!getDataType().equals(PositionDataType.INSTANCE) &&
+                !getDataType().equals(DataType.getArray(PositionDataType.INSTANCE)) &&
+                hasAttributeExpression(exp))
+            {
+                throw new IllegalArgumentException("For field '" + getName() + "': Setting attribute on a field that has struct or map sub-type(s) is not supported");
+            }
         }
         for (SDField structField : getStructFields()) {
             structField.setIndexingScript(exp);
         }
     }
 
+    private static boolean hasAttributeExpression(ScriptExpression exp) {
+        var visitor = new ExpressionVisitor() {
+            boolean result = false;
+            @Override
+            protected void doVisit(Expression exp) {
+                if (exp instanceof AttributeExpression) {
+                    result = true;
+                }
+            }
+        };
+        visitor.visit(exp);
+        return visitor.result;
+    }
+
     @Override
     public ScriptExpression getIndexingScript() {
         return indexingScript;