aboutsummaryrefslogtreecommitdiffstats
path: root/config-model/src/main/java/com/yahoo/searchdefinition
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2019-06-12 15:16:40 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2019-06-12 15:16:40 +0200
commitb0617250359afddefabb1dc2d26dec288fa3e3d8 (patch)
tree67e0ef866f22c55e55788fc3c2c732a340126eab /config-model/src/main/java/com/yahoo/searchdefinition
parentd3e5bf770cf893f7a9196fa49b07eae651d3c688 (diff)
We should not need to put any fields from the default summary class in the document.
At least not the ones generated specially for summary classes.
Diffstat (limited to 'config-model/src/main/java/com/yahoo/searchdefinition')
-rw-r--r--config-model/src/main/java/com/yahoo/searchdefinition/processing/AddExtraFieldsToDocument.java10
1 files changed, 9 insertions, 1 deletions
diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/processing/AddExtraFieldsToDocument.java b/config-model/src/main/java/com/yahoo/searchdefinition/processing/AddExtraFieldsToDocument.java
index 233075155b5..f846eabbff8 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/processing/AddExtraFieldsToDocument.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/processing/AddExtraFieldsToDocument.java
@@ -25,6 +25,11 @@ public class AddExtraFieldsToDocument extends Processor {
super(search, deployLogger, rankProfileRegistry, queryProfiles);
}
+ //TODO This is a tempoarry hack to avoid producing illegal code for fields not wanted anyway.
+ private boolean dirtyLegalFieldNameCheck(String fieldName) {
+ return ! fieldName.contains(".");
+ }
+
@Override
public void process(boolean validate, boolean documentsOnly) {
SDDocumentType document = search.getDocument();
@@ -32,8 +37,11 @@ public class AddExtraFieldsToDocument extends Processor {
for (Field field : search.extraFieldList()) {
addSdField(search, document, (SDField)field, validate);
}
+ //TODO Vespa 8 or sooner we should avoid the dirty addition of fields from dirty 'default' summary to document at all
for (SummaryField field : search.getSummary("default").getSummaryFields()) {
- addSummaryField(search, document, field, validate);
+ if (dirtyLegalFieldNameCheck(field.getName())) {
+ addSummaryField(search, document, field, validate);
+ }
}
}
}