summaryrefslogtreecommitdiffstats
path: root/config-model/src/main/java/com/yahoo/searchdefinition
diff options
context:
space:
mode:
authorBjørn Christian Seime <bjorncs@yahoo-inc.com>2017-03-29 13:56:51 +0200
committerBjørn Christian Seime <bjorncs@yahoo-inc.com>2017-04-03 11:20:29 +0200
commite106383cfbf41f1691618fec1a2c3f5168c4c130 (patch)
treeaf811692d3e55964b0406d36d7cb40dcb8c41e42 /config-model/src/main/java/com/yahoo/searchdefinition
parent2b6924ad487df4ade66bf4560280b3a8d3d006d4 (diff)
Include imported fields when validating field types
Diffstat (limited to 'config-model/src/main/java/com/yahoo/searchdefinition')
-rw-r--r--config-model/src/main/java/com/yahoo/searchdefinition/processing/ValidateFieldTypes.java11
1 files changed, 5 insertions, 6 deletions
diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/processing/ValidateFieldTypes.java b/config-model/src/main/java/com/yahoo/searchdefinition/processing/ValidateFieldTypes.java
index 63610fd623c..6bda869828f 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/processing/ValidateFieldTypes.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/processing/ValidateFieldTypes.java
@@ -2,12 +2,11 @@
package com.yahoo.searchdefinition.processing;
import com.yahoo.config.application.api.DeployLogger;
+import com.yahoo.document.DataType;
import com.yahoo.document.TensorDataType;
import com.yahoo.searchdefinition.RankProfileRegistry;
-import com.yahoo.searchdefinition.document.Attribute;
-import com.yahoo.document.DataType;
-import com.yahoo.searchdefinition.document.SDField;
import com.yahoo.searchdefinition.Search;
+import com.yahoo.searchdefinition.document.Attribute;
import com.yahoo.vespa.documentmodel.DocumentSummary;
import com.yahoo.vespa.documentmodel.SummaryField;
import com.yahoo.vespa.model.container.search.QueryProfiles;
@@ -32,12 +31,12 @@ public class ValidateFieldTypes extends Processor {
public void process() {
String searchName = search.getName();
Map<String, DataType> seenFields = new HashMap<>();
- for (SDField field : search.allConcreteFields()) {
+ search.allFields().forEach(field -> {
checkFieldType(searchName, "index field", field.getName(), field.getDataType(), seenFields);
for (Map.Entry<String, Attribute> entry : field.getAttributes().entrySet()) {
checkFieldType(searchName, "attribute", entry.getKey(), entry.getValue().getDataType(), seenFields);
}
- }
+ });
for (DocumentSummary summary : search.getSummaries().values()) {
for (SummaryField field : summary.getSummaryFields()) {
checkFieldType(searchName, "summary field", field.getName(), field.getDataType(), seenFields);
@@ -57,7 +56,7 @@ public class ValidateFieldTypes extends Processor {
}
}
- private boolean compatibleTypes(DataType seenType, DataType fieldType) {
+ private static boolean compatibleTypes(DataType seenType, DataType fieldType) {
// legacy tag field type compatibility; probably not needed any more (Oct 2016)
if ("tag".equals(seenType.getName())) {
return "tag".equals(fieldType.getName()) || "WeightedSet<string>".equals(fieldType.getName());