aboutsummaryrefslogtreecommitdiffstats
path: root/config-model/src/main/java/com/yahoo
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2019-08-14 08:21:18 +0200
committerHarald Musum <musum@verizonmedia.com>2019-08-14 08:21:18 +0200
commitaf8ac01b3883882c792cc872b03aa77ef81a179a (patch)
tree79e761fd933bcd1b90fa37da720d597fb0c72137 /config-model/src/main/java/com/yahoo
parent23566b7d1b574cf21bfdfc587706f2bddebc29c9 (diff)
Cleanup of config definition name and namespace
Config definition name and namespace are mandatory, so no need to fallback to default namespace anymore
Diffstat (limited to 'config-model/src/main/java/com/yahoo')
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/InstanceResolver.java3
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomConfigPayloadBuilder.java4
2 files changed, 5 insertions, 2 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/InstanceResolver.java b/config-model/src/main/java/com/yahoo/vespa/model/InstanceResolver.java
index f90b399d305..a8404b076d4 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/InstanceResolver.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/InstanceResolver.java
@@ -135,8 +135,7 @@ class InstanceResolver {
}
static String packageName(ConfigDefinitionKey cKey, PackagePrefix packagePrefix) {
- String prefix = packagePrefix.value;
- return prefix + (cKey.getNamespace().isEmpty() ? CNode.DEFAULT_NAMESPACE : cKey.getNamespace());
+ return packagePrefix.value + cKey.getNamespace();
}
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomConfigPayloadBuilder.java b/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomConfigPayloadBuilder.java
index d07f6c4e6fd..31231857aae 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomConfigPayloadBuilder.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/DomConfigPayloadBuilder.java
@@ -86,11 +86,15 @@ public class DomConfigPayloadBuilder {
}
private static boolean validName(String name) {
+ if (name == null) return false;
+
Matcher m = namePattern.matcher(name);
return m.matches();
}
private static boolean validNamespace(String namespace) {
+ if (namespace == null) return false;
+
Matcher m = namespacePattern.matcher(namespace);
return m.matches();
}