refactor after review

1 files changed, 10 insertions, 10 deletions

diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/derived/AttributeFields.java b/config-model/src/main/java/com/yahoo/searchdefinition/derived/AttributeFields.java
index f3ac7a59549..7acf5557236 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/derived/AttributeFields.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/derived/AttributeFields.java
@@ -100,17 +100,21 @@ public class AttributeFields extends Derived implements AttributesConfig.Produce
         }
     }
 
+    private void applyRanking(ImmutableSDField field, Attribute attribute) {
+        Ranking ranking = field.getRanking();
+        if (ranking != null && ranking.isFilter()) {
+            attribute.setEnableBitVectors(true);
+            attribute.setEnableOnlyBitVector(true);
+        }
+    }
+
     private void deriveAttribute(ImmutableSDField field, Attribute fieldAttribute) {
         Attribute attribute = getAttribute(fieldAttribute.getName());
         if (attribute == null) {
             attributes.put(fieldAttribute.getName(), fieldAttribute);
             attribute = getAttribute(fieldAttribute.getName());
         }
-        Ranking ranking = field.getRanking();
-        if (ranking != null && ranking.isFilter()) {
-            attribute.setEnableBitVectors(true);
-            attribute.setEnableOnlyBitVector(true);
-        }
+        applyRanking(field, attribute);
     }
 
     private void deriveImportedAttributes(ImmutableSDField field) {
@@ -134,11 +138,7 @@ public class AttributeFields extends Derived implements AttributesConfig.Produce
         }
         Attribute attribute = field.getAttributes().get(field.getName());
         if (attribute != null) {
-            Ranking ranking = field.getRanking();
-            if (ranking != null && ranking.isFilter()) {
-                attribute.setEnableBitVectors(true);
-                attribute.setEnableOnlyBitVector(true);
-            }
+            applyRanking(field, attribute);
             attributes.put(attribute.getName(), attribute.convertToArray());
         }
     }