diff options
author | Geir Storli <geirst@yahooinc.com> | 2022-07-12 17:29:20 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-07-12 17:29:20 +0200 |
commit | f0dc42821e54ab6ceb2f79d3242300134e690e61 (patch) | |
tree | 7943b9da9e5cf6a8dc3548f8c17dc36ebfe0b8b5 /config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java | |
parent | 393c46b52cb3580e563d755478481a197522553d (diff) | |
parent | a82fcc5b74a6fb788e29103585779bcae2af5ad7 (diff) |
Merge pull request #23465 from vespa-engine/geirst/summary-transform-for-documentid-fieldsv8.17.19
Add new summary transform for all 'documentid' summary fields.
Diffstat (limited to 'config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java')
-rw-r--r-- | config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java | 25 |
1 files changed, 22 insertions, 3 deletions
diff --git a/config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java b/config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java index f0fc58b97e5..2f1b837554d 100644 --- a/config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java +++ b/config-model/src/test/java/com/yahoo/schema/derived/SummaryMapTestCase.java @@ -162,23 +162,42 @@ public class SummaryMapTestCase extends AbstractSchemaTestCase { assertFalse(SummaryMap.isDynamicCommand(SummaryTransform.ATTRIBUTE.getName())); } + @Test + public void documentid_summary_field_has_corresponding_summary_transform() throws ParseException { + var schema = buildSchema("field foo type string { indexing: summary }", + joinLines("document-summary bar {", + " summary documentid type string {}", + "}")); + assertOverride(schema, "documentid", SummaryTransform.DOCUMENT_ID.getName(), ""); + } + + @Test + public void documentid_summary_transform_requires_disk_access() { + assertFalse(SummaryTransform.DOCUMENT_ID.isInMemory()); + } + private void assertOverride(String fieldContent, String expFieldName, String expCommand) throws ParseException { - var summaryMap = new SummaryMap(buildSearch(fieldContent)); + assertOverride(buildSchema(fieldContent, ""), expFieldName, expCommand, expFieldName); + } + + private void assertOverride(Schema schema, String expFieldName, String expCommand, String expArguments) throws ParseException { + var summaryMap = new SummaryMap(schema); var cfgBuilder = new SummarymapConfig.Builder(); summaryMap.getConfig(cfgBuilder); var cfg = new SummarymapConfig(cfgBuilder); var override = cfg.override(0); assertEquals(expFieldName, override.field()); assertEquals(expCommand, override.command()); - assertEquals(expFieldName, override.arguments()); + assertEquals(expArguments, override.arguments()); } - private Schema buildSearch(String field) throws ParseException { + private Schema buildSchema(String field, String documentSummary) throws ParseException { var builder = new ApplicationBuilder(new RankProfileRegistry()); builder.addSchema(joinLines("search test {", " document test {", field, " }", + documentSummary, "}")); builder.build(true); return builder.getSchema(); |