diff options
author | Geir Storli <geirst@yahooinc.com> | 2023-10-31 12:56:39 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-10-31 12:56:39 +0100 |
commit | c91d0b4f188c48f317f2029e3ec0abc05180d2f1 (patch) | |
tree | 5623510c07cfcf88d656bcf0b409935102e46cff /config-model/src/test | |
parent | 7c150cdc0bab88d5913de557fd24c31cd3bf18b4 (diff) | |
parent | 8611ee3088ec17f2200a6b242515558dc958c53b (diff) |
Merge pull request #29166 from vespa-engine/toregge/add-attribute-tokens-summary-transform-to-config-model
Add attribute-tokens summary transform to config model.
Diffstat (limited to 'config-model/src/test')
-rw-r--r-- | config-model/src/test/java/com/yahoo/schema/derived/SummaryTestCase.java | 25 | ||||
-rw-r--r-- | config-model/src/test/java/com/yahoo/schema/processing/TokensTransformValidatorTest.java | 2 |
2 files changed, 22 insertions, 5 deletions
diff --git a/config-model/src/test/java/com/yahoo/schema/derived/SummaryTestCase.java b/config-model/src/test/java/com/yahoo/schema/derived/SummaryTestCase.java index 5019ed0dd60..5e02f63ec39 100644 --- a/config-model/src/test/java/com/yahoo/schema/derived/SummaryTestCase.java +++ b/config-model/src/test/java/com/yahoo/schema/derived/SummaryTestCase.java @@ -25,6 +25,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.fail; /** * Tests summary extraction @@ -226,9 +227,10 @@ public class SummaryTestCase extends AbstractSchemaTestCase { assertOverride(schema, "documentid", SummaryTransform.DOCUMENT_ID.getName(), "", "bar"); } - @Test - void tokens_override() throws ParseException { - var schema = buildSchema("field foo type string { indexing: summary }", + private void check_tokens_override(boolean index, boolean attribute, SummaryTransform exp) throws ParseException { + var schema = buildSchema("field foo type string { indexing: " + + (index ? "index | " : "") + + (attribute ? "attribute | " : "") + "summary }", joinLines("document-summary bar {", " summary baz {", " source: foo ", @@ -236,11 +238,26 @@ public class SummaryTestCase extends AbstractSchemaTestCase { " }", " from-disk", "}")); - assertOverride(schema, "baz", SummaryTransform.TOKENS.getName(), "foo", "bar"); + assertOverride(schema, "baz", exp.getName(), "foo", "bar"); assert(!schema.getSummary("default").getSummaryFields().containsKey("baz")); } @Test + void tokens_override() throws ParseException { + try { + check_tokens_override(false, false, SummaryTransform.TOKENS); + fail("Expected IllegalArgumentException"); + } catch (IllegalArgumentException e) { + assertEquals("For schema 'test', document-summary 'bar'" + + ", summary field 'baz', source field 'foo'" + + ": tokens summary field setting requires index or attribute for source field", e.getMessage()); + } + check_tokens_override(false, true, SummaryTransform.ATTRIBUTE_TOKENS); + check_tokens_override(true, false, SummaryTransform.TOKENS); + check_tokens_override(true, true, SummaryTransform.TOKENS); + } + + @Test void documentid_summary_transform_requires_disk_access() { assertFalse(SummaryTransform.DOCUMENT_ID.isInMemory()); } diff --git a/config-model/src/test/java/com/yahoo/schema/processing/TokensTransformValidatorTest.java b/config-model/src/test/java/com/yahoo/schema/processing/TokensTransformValidatorTest.java index 6ca62321617..6da536efe86 100644 --- a/config-model/src/test/java/com/yahoo/schema/processing/TokensTransformValidatorTest.java +++ b/config-model/src/test/java/com/yahoo/schema/processing/TokensTransformValidatorTest.java @@ -17,7 +17,7 @@ public class TokensTransformValidatorTest { "search test {", " document test {", " field f type " + fieldType + " {", - " indexing: summary", + " indexing: index | summary", " summary: tokens", " }", " }", |