summaryrefslogtreecommitdiffstats
path: root/config-model/src
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2023-12-12 10:47:38 +0100
committerHarald Musum <musum@yahooinc.com>2023-12-12 10:47:38 +0100
commite37b16443c44329c9b9e438ff294ade56d089fa3 (patch)
treea11d132fa7afdc8e958bd5ac82d2c453c9d7d681 /config-model/src
parentb41221bfb9894d0182eef237a0e1c0d4f8130c00 (diff)
Make sure to set restart on deploy also when model set changes
Diffstat (limited to 'config-model/src')
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/RestartOnDeployForOnnxModelChangesValidator.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/RestartOnDeployForOnnxModelChangesValidator.java b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/RestartOnDeployForOnnxModelChangesValidator.java
index b1189dbf923..355bce24c0f 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/RestartOnDeployForOnnxModelChangesValidator.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/change/RestartOnDeployForOnnxModelChangesValidator.java
@@ -62,8 +62,7 @@ public class RestartOnDeployForOnnxModelChangesValidator implements ChangeValida
modelChanged(nextModelInfo, currentModels.get(nextModelInfo.modelId())).ifPresent(change -> {
String message = "Onnx model '%s' has changed (%s), need to restart services in %s"
.formatted(nextModelInfo.modelId(), change, cluster);
- cluster.onnxModelCostCalculator().setRestartOnDeploy();
- addRestartAction(actions, cluster, message);
+ setRestartOnDeployAndAddRestartAction(actions, cluster, message);
});
}
return actions;
@@ -79,7 +78,7 @@ public class RestartOnDeployForOnnxModelChangesValidator implements ChangeValida
if (! currentModelIds.equals(nextModelIds)) {
String message = "Onnx model set has changed from %s to %s, need to restart services in %s"
.formatted(currentModelIds, nextModelIds, cluster);
- addRestartAction(actions, cluster, message);
+ setRestartOnDeployAndAddRestartAction(actions, cluster, message);
}
return actions;
}
@@ -94,7 +93,8 @@ public class RestartOnDeployForOnnxModelChangesValidator implements ChangeValida
return Optional.empty();
}
- private static void addRestartAction(List<ConfigChangeAction> actions, ApplicationContainerCluster cluster, String message) {
+ private static void setRestartOnDeployAndAddRestartAction(List<ConfigChangeAction> actions, ApplicationContainerCluster cluster, String message) {
+ cluster.onnxModelCostCalculator().setRestartOnDeploy();
actions.add(new VespaRestartAction(cluster.id(), message));
}