diff options
author | Harald Musum <musum@yahooinc.com> | 2022-09-22 13:11:42 +0200 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2022-09-22 13:11:42 +0200 |
commit | 9e2bc23337cc410e04217bbfdab87cb0f892ec08 (patch) | |
tree | 253ec345801edc550b173f2f6a189813c9e0db24 /config-model | |
parent | 1957bf2e63c2ad903bd1f6ccbde48de1141dca11 (diff) |
Set deature flag and config value for cluster-controller-state-gather-count to 1
Diffstat (limited to 'config-model')
3 files changed, 7 insertions, 18 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/ClusterControllerConfig.java b/config-model/src/main/java/com/yahoo/vespa/model/content/ClusterControllerConfig.java index 642b182f0b7..df70f7c3158 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/content/ClusterControllerConfig.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/content/ClusterControllerConfig.java @@ -1,11 +1,10 @@ // Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root. package com.yahoo.vespa.model.content; -import com.yahoo.config.model.api.ModelContext; import com.yahoo.config.model.deploy.DeployState; -import com.yahoo.vespa.config.content.FleetcontrollerConfig; import com.yahoo.config.model.producer.AbstractConfigProducer; import com.yahoo.config.model.producer.AbstractConfigProducerRoot; +import com.yahoo.vespa.config.content.FleetcontrollerConfig; import com.yahoo.vespa.model.VespaModel; import com.yahoo.vespa.model.builder.xml.dom.ModelElement; import com.yahoo.vespa.model.builder.xml.dom.VespaDomBuilder; @@ -23,13 +22,11 @@ public class ClusterControllerConfig extends AbstractConfigProducer<ClusterContr private final String clusterName; private final ModelElement clusterElement; private final ResourceLimits resourceLimits; - private final int clusterControllerStateGatherCount; - public Builder(String clusterName, ModelElement clusterElement, ResourceLimits resourceLimits, ModelContext.FeatureFlags featureFlags) { + public Builder(String clusterName, ModelElement clusterElement, ResourceLimits resourceLimits) { this.clusterName = clusterName; this.clusterElement = clusterElement; this.resourceLimits = resourceLimits; - this.clusterControllerStateGatherCount = featureFlags.clusterControllerStateGatherCount(); } @Override @@ -55,15 +52,13 @@ public class ClusterControllerConfig extends AbstractConfigProducer<ClusterContr tuning.childAsDouble("min-storage-up-ratio"), bucketSplittingMinimumBits, minNodeRatioPerGroup, - resourceLimits, - clusterControllerStateGatherCount); + resourceLimits); } else { return new ClusterControllerConfig(ancestor, clusterName, null, null, null, null, null, null, bucketSplittingMinimumBits, minNodeRatioPerGroup, - resourceLimits, - clusterControllerStateGatherCount); + resourceLimits); } } } @@ -78,7 +73,6 @@ public class ClusterControllerConfig extends AbstractConfigProducer<ClusterContr private final Integer minSplitBits; private final Double minNodeRatioPerGroup; private final ResourceLimits resourceLimits; - private final int clusterControllerStateGatherCount; // TODO refactor; too many args private ClusterControllerConfig(AbstractConfigProducer<?> parent, @@ -91,8 +85,7 @@ public class ClusterControllerConfig extends AbstractConfigProducer<ClusterContr Double minStorageUpRatio, Integer minSplitBits, Double minNodeRatioPerGroup, - ResourceLimits resourceLimits, - int clusterControllerStateGatherCount) { + ResourceLimits resourceLimits) { super(parent, "fleetcontroller"); this.clusterName = clusterName; @@ -105,7 +98,6 @@ public class ClusterControllerConfig extends AbstractConfigProducer<ClusterContr this.minSplitBits = minSplitBits; this.minNodeRatioPerGroup = minNodeRatioPerGroup; this.resourceLimits = resourceLimits; - this.clusterControllerStateGatherCount = clusterControllerStateGatherCount; } @Override @@ -148,7 +140,6 @@ public class ClusterControllerConfig extends AbstractConfigProducer<ClusterContr builder.min_node_ratio_per_group(minNodeRatioPerGroup); } resourceLimits.getConfig(builder); - builder.state_gather_count(clusterControllerStateGatherCount); } } diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/ContentCluster.java b/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/ContentCluster.java index e777999cfbe..bf5770681ef 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/ContentCluster.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/ContentCluster.java @@ -127,8 +127,7 @@ public class ContentCluster extends AbstractConfigProducer<AbstractConfigProduce .build(contentElement); c.clusterControllerConfig = new ClusterControllerConfig.Builder(clusterId, contentElement, - resourceLimits.getClusterControllerLimits(), - deployState.featureFlags()) + resourceLimits.getClusterControllerLimits()) .build(deployState, c, contentElement.getXml()); c.search = new ContentSearchCluster.Builder(documentDefinitions, globallyDistributedDocuments, diff --git a/config-model/src/test/java/com/yahoo/vespa/model/content/FleetControllerClusterTest.java b/config-model/src/test/java/com/yahoo/vespa/model/content/FleetControllerClusterTest.java index b449d5403b5..1e6847a47be 100644 --- a/config-model/src/test/java/com/yahoo/vespa/model/content/FleetControllerClusterTest.java +++ b/config-model/src/test/java/com/yahoo/vespa/model/content/FleetControllerClusterTest.java @@ -27,8 +27,7 @@ public class FleetControllerClusterTest { new ClusterResourceLimits.Builder(false, featureFlags.resourceLimitDisk(), featureFlags.resourceLimitMemory()) - .build(clusterElement).getClusterControllerLimits(), - new TestProperties().featureFlags()) + .build(clusterElement).getClusterControllerLimits()) .build(root.getDeployState(), root, clusterElement.getXml()); } |