summaryrefslogtreecommitdiffstats
path: root/config-model
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2023-01-10 12:16:26 +0100
committergjoranv <gv@verizonmedia.com>2023-01-10 12:21:17 +0100
commit346baa816ebeec7b65275b904d244e64b7dfc4be (patch)
tree5f5453629cebafb38d2f38793f4734ec2e7c9668 /config-model
parent81ff2fed4a50dbc2f9f82a9a59f2d880fb6358c1 (diff)
Use the initially included metrics in the new metrics enum.
Diffstat (limited to 'config-model')
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/DefaultMetrics.java14
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/VespaMetricSet.java18
2 files changed, 18 insertions, 14 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/DefaultMetrics.java b/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/DefaultMetrics.java
index 6f4535bf4a1..dcd3c10c01b 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/DefaultMetrics.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/DefaultMetrics.java
@@ -2,6 +2,8 @@
package com.yahoo.vespa.model.admin.monitoring;
+import com.yahoo.metrics.ContainerMetrics;
+
import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.Set;
@@ -36,12 +38,12 @@ public class DefaultMetrics {
}
private static void addContainerMetrics(Set<Metric> metrics) {
- metrics.add(new Metric("http.status.1xx.rate"));
- metrics.add(new Metric("http.status.2xx.rate"));
- metrics.add(new Metric("http.status.3xx.rate"));
- metrics.add(new Metric("http.status.4xx.rate"));
- metrics.add(new Metric("http.status.5xx.rate"));
- metrics.add(new Metric("jdisc.gc.ms.average"));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_1XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_2XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_3XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_4XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_5XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.JDISC_GC_MS.average()));
metrics.add(new Metric("mem.heap.free.average"));
}
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/VespaMetricSet.java b/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/VespaMetricSet.java
index 4d4670aeedc..2c4b81c6db8 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/VespaMetricSet.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/admin/monitoring/VespaMetricSet.java
@@ -1,6 +1,8 @@
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.admin.monitoring;
+import com.yahoo.metrics.ContainerMetrics;
+
import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.List;
@@ -197,9 +199,9 @@ public class VespaMetricSet {
metrics.add(new Metric("jdisc.gc.count.average"));
metrics.add(new Metric("jdisc.gc.count.max"));
metrics.add(new Metric("jdisc.gc.count.last"));
- metrics.add(new Metric("jdisc.gc.ms.average"));
- metrics.add(new Metric("jdisc.gc.ms.max"));
- metrics.add(new Metric("jdisc.gc.ms.last"));
+ metrics.add(new Metric(ContainerMetrics.JDISC_GC_MS.average()));
+ metrics.add(new Metric(ContainerMetrics.JDISC_GC_MS.max()));
+ metrics.add(new Metric(ContainerMetrics.JDISC_GC_MS.last()));
metrics.add(new Metric("jdisc.deactivated_containers.total.last"));
metrics.add(new Metric("jdisc.deactivated_containers.with_retained_refs.last"));
@@ -218,11 +220,11 @@ public class VespaMetricSet {
metrics.add(new Metric("jdisc.http.request.prematurely_closed.rate"));
addMetric(metrics, "jdisc.http.request.requests_per_connection", List.of("sum", "count", "min", "max", "average"));
- metrics.add(new Metric("http.status.1xx.rate"));
- metrics.add(new Metric("http.status.2xx.rate"));
- metrics.add(new Metric("http.status.3xx.rate"));
- metrics.add(new Metric("http.status.4xx.rate"));
- metrics.add(new Metric("http.status.5xx.rate"));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_1XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_2XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_3XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_4XX.rate()));
+ metrics.add(new Metric(ContainerMetrics.HTTP_STATUS_5XX.rate()));
metrics.add(new Metric("jdisc.http.request.uri_length.max"));
metrics.add(new Metric("jdisc.http.request.uri_length.sum"));