summaryrefslogtreecommitdiffstats
path: root/config-model
diff options
context:
space:
mode:
authorgjoranv <gjoranv@gmail.com>2017-12-17 21:44:49 +0100
committerGitHub <noreply@github.com>2017-12-17 21:44:49 +0100
commit03bce1fe1a494f2ac9d4268d4c90b08011b3f600 (patch)
tree180f294d2ac97d641f0266216ffdc328db9bfef8 /config-model
parentb72e55b87eecae006ed92976151137a80d75be0f (diff)
Revert "Bratseth/tensorflow models"
Diffstat (limited to 'config-model')
-rw-r--r--config-model/src/main/java/com/yahoo/searchdefinition/TensorTransformer.java2
-rw-r--r--config-model/src/main/java/com/yahoo/searchdefinition/document/Attribute.java2
-rw-r--r--config-model/src/main/java/com/yahoo/searchdefinition/document/ImmutableImportedSDField.java20
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/configmodel/producers/DocumentManager.java2
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/application/validation/ConstantTensorJsonValidator.java2
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/application/validation/RankingConstantsValidator.java2
-rw-r--r--config-model/src/main/java/com/yahoo/vespa/model/content/cluster/RedundancyBuilder.java2
-rw-r--r--config-model/src/test/java/com/yahoo/searchdefinition/RankProfileTestCase.java2
-rw-r--r--config-model/src/test/java/com/yahoo/searchdefinition/derived/ExportingTestCase.java2
-rw-r--r--config-model/src/test/java/com/yahoo/searchdefinition/processing/TensorTransformTestCase.java2
10 files changed, 18 insertions, 20 deletions
diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/TensorTransformer.java b/config-model/src/main/java/com/yahoo/searchdefinition/TensorTransformer.java
index 65176006a2a..69e353ceb35 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/TensorTransformer.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/TensorTransformer.java
@@ -118,7 +118,7 @@ public class TensorTransformer extends ExpressionTransformer {
private ExpressionNode replaceMaxAndMinFunction(FunctionNode node) {
ExpressionNode arg1 = node.children().get(0);
ExpressionNode arg2 = node.children().get(1);
-
+
TensorFunctionNode.TensorFunctionExpressionNode expression = TensorFunctionNode.wrapArgument(arg1);
Reduce.Aggregator aggregator = Reduce.Aggregator.valueOf(node.getFunction().name());
String dimension = ((ReferenceNode) arg2).getName();
diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/document/Attribute.java b/config-model/src/main/java/com/yahoo/searchdefinition/document/Attribute.java
index f932265cb93..c52a5dc465d 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/document/Attribute.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/document/Attribute.java
@@ -259,7 +259,7 @@ public final class Attribute implements Cloneable, Serializable {
throw new IllegalArgumentException("Field " + fieldType + " not supported in convertCollectionType");
}
}
-
+
private static Optional<TensorType> convertTensorType(DataType fieldType) {
if ( ! ( fieldType instanceof TensorDataType)) return Optional.empty();
return Optional.of(((TensorDataType)fieldType).getTensorType());
diff --git a/config-model/src/main/java/com/yahoo/searchdefinition/document/ImmutableImportedSDField.java b/config-model/src/main/java/com/yahoo/searchdefinition/document/ImmutableImportedSDField.java
index 8b6df1a87db..c8918f39834 100644
--- a/config-model/src/main/java/com/yahoo/searchdefinition/document/ImmutableImportedSDField.java
+++ b/config-model/src/main/java/com/yahoo/searchdefinition/document/ImmutableImportedSDField.java
@@ -29,7 +29,7 @@ public class ImmutableImportedSDField implements ImmutableSDField {
@Override
public <T extends Expression> boolean containsExpression(Class<T> searchFor) {
- throw createUnsupportedException(searchFor.getSimpleName());
+ throw createUnsupportedException();
}
@Override
@@ -79,9 +79,9 @@ public class ImmutableImportedSDField implements ImmutableSDField {
@Override
public Index getIndex(String name) {
- if ( ! importedField.fieldName().equals(name)) {
+ if (!importedField.fieldName().equals(name)) {
throw new IllegalArgumentException("Getting an index (" + name + ") with different name than the imported field ("
- + importedField.fieldName() + ") is not supported");
+ + importedField.fieldName() + ") is not supported");
}
String targetIndexName = importedField.targetField().getName();
return importedField.targetField().getIndex(targetIndexName);
@@ -104,7 +104,7 @@ public class ImmutableImportedSDField implements ImmutableSDField {
@Override
public ScriptExpression getIndexingScript() {
- throw createUnsupportedException("indexing");
+ throw createUnsupportedException();
}
@Override
@@ -119,12 +119,12 @@ public class ImmutableImportedSDField implements ImmutableSDField {
@Override
public ImmutableSDField getStructField(String name) {
- throw createUnsupportedException("struct");
+ throw createUnsupportedException();
}
@Override
public Collection<? extends ImmutableSDField> getStructFields() {
- throw createUnsupportedException("struct");
+ throw createUnsupportedException();
}
@Override
@@ -134,12 +134,12 @@ public class ImmutableImportedSDField implements ImmutableSDField {
@Override
public Stemming getStemming(Search search) {
- throw createUnsupportedException("stemming");
+ throw createUnsupportedException();
}
@Override
public Ranking getRanking() {
- throw createUnsupportedException("ranking");
+ throw createUnsupportedException();
}
@Override
@@ -158,8 +158,8 @@ public class ImmutableImportedSDField implements ImmutableSDField {
importedField.targetField().getDataType());
}
- private static UnsupportedOperationException createUnsupportedException(String aspect) {
- return new UnsupportedOperationException("'" + aspect + "' is not meaningful or relevant for an imported field.");
+ private static UnsupportedOperationException createUnsupportedException() {
+ return new UnsupportedOperationException("This aspect is not meaningful or relevant for an imported field.");
}
}
diff --git a/config-model/src/main/java/com/yahoo/vespa/configmodel/producers/DocumentManager.java b/config-model/src/main/java/com/yahoo/vespa/configmodel/producers/DocumentManager.java
index 9368d6aaa39..96a9448739a 100644
--- a/config-model/src/main/java/com/yahoo/vespa/configmodel/producers/DocumentManager.java
+++ b/config-model/src/main/java/com/yahoo/vespa/configmodel/producers/DocumentManager.java
@@ -20,7 +20,7 @@ import java.util.Set;
*/
public class DocumentManager {
- public DocumentmanagerConfig.Builder produce(DocumentModel model,
+ public DocumentmanagerConfig.Builder produce(DocumentModel model,
DocumentmanagerConfig.Builder documentConfigBuilder) {
documentConfigBuilder.enablecompression(false);
Set<DataType> handled = new HashSet<>();
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/ConstantTensorJsonValidator.java b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/ConstantTensorJsonValidator.java
index ce3c04f41f7..6eeb12ffdd9 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/ConstantTensorJsonValidator.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/ConstantTensorJsonValidator.java
@@ -45,7 +45,7 @@ public class ConstantTensorJsonValidator {
throw new IllegalArgumentException("Ranking constant file names must end with either '.json' or '.json.lz4'");
}
}
-
+
private void validateTensor(TensorType type, Reader tensorData) {
wrapIOException(() -> {
this.parser = jsonFactory.createParser(tensorData);
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/RankingConstantsValidator.java b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/RankingConstantsValidator.java
index c686f023d5b..4a9310799aa 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/application/validation/RankingConstantsValidator.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/application/validation/RankingConstantsValidator.java
@@ -64,7 +64,7 @@ public class RankingConstantsValidator extends Validator {
private void validateRankingConstant(RankingConstant rankingConstant, ApplicationPackage applicationPackage) throws FileNotFoundException {
ApplicationFile tensorApplicationFile = applicationPackage.getFile(Path.fromString(rankingConstant.getFileName()));
- new ConstantTensorJsonValidator().validate(rankingConstant.getFileName(),
+ new ConstantTensorJsonValidator().validate(rankingConstant.getFileName(),
rankingConstant.getTensorType(),
tensorApplicationFile.createReader());
}
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/RedundancyBuilder.java b/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/RedundancyBuilder.java
index e1675007bbc..a5b7d67e377 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/RedundancyBuilder.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/content/cluster/RedundancyBuilder.java
@@ -8,7 +8,6 @@ import com.yahoo.vespa.model.content.Redundancy;
* Builds redundancy config for a content cluster.
*/
public class RedundancyBuilder {
-
Redundancy build(ModelElement clusterXml) {
Integer initialRedundancy = 2;
Integer finalRedundancy = 3;
@@ -38,5 +37,4 @@ public class RedundancyBuilder {
return new Redundancy(initialRedundancy, finalRedundancy, readyCopies);
}
-
}
diff --git a/config-model/src/test/java/com/yahoo/searchdefinition/RankProfileTestCase.java b/config-model/src/test/java/com/yahoo/searchdefinition/RankProfileTestCase.java
index 960a3b7d6db..9407c21fee8 100644
--- a/config-model/src/test/java/com/yahoo/searchdefinition/RankProfileTestCase.java
+++ b/config-model/src/test/java/com/yahoo/searchdefinition/RankProfileTestCase.java
@@ -173,7 +173,7 @@ public class RankProfileTestCase extends SearchDefinitionTestCase {
assertFalse(findProperty(rawProfile.configProperties(), "vespa.type.query.tensor3").isPresent());
assertFalse(findProperty(rawProfile.configProperties(), "vespa.type.query.numeric").isPresent());
}
-
+
private static Optional<String> findProperty(List<Pair<String, String>> properties, String key) {
for (Pair<String, String> property : properties)
if (property.getFirst().equals(key))
diff --git a/config-model/src/test/java/com/yahoo/searchdefinition/derived/ExportingTestCase.java b/config-model/src/test/java/com/yahoo/searchdefinition/derived/ExportingTestCase.java
index 4600f6ae4c6..7cd00e155bb 100644
--- a/config-model/src/test/java/com/yahoo/searchdefinition/derived/ExportingTestCase.java
+++ b/config-model/src/test/java/com/yahoo/searchdefinition/derived/ExportingTestCase.java
@@ -123,7 +123,7 @@ public class ExportingTestCase extends AbstractExportingTestCase {
public void testIndexinfoFieldsets() throws IOException, ParseException {
assertCorrectDeriving("indexinfo_fieldsets");
}
-
+
@Test
public void testStreamingJuniper() throws IOException, ParseException {
assertCorrectDeriving("streamingjuniper");
diff --git a/config-model/src/test/java/com/yahoo/searchdefinition/processing/TensorTransformTestCase.java b/config-model/src/test/java/com/yahoo/searchdefinition/processing/TensorTransformTestCase.java
index e5693d24f0f..12bdd8d2b5c 100644
--- a/config-model/src/test/java/com/yahoo/searchdefinition/processing/TensorTransformTestCase.java
+++ b/config-model/src/test/java/com/yahoo/searchdefinition/processing/TensorTransformTestCase.java
@@ -202,5 +202,5 @@ public class TensorTransformTestCase extends SearchDefinitionTestCase {
}
return b.toString();
}
-
+
}