diff options
author | Harald Musum <musum@verizonmedia.com> | 2020-01-30 12:08:21 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-30 12:08:21 +0100 |
commit | 70915ed4ea7fe40bcacc2f2bf3b93f36ae79163d (patch) | |
tree | 1c6de423a536ca1083a8720dc4710b04727df4ca /config-model | |
parent | f890daf491f1e9ceb536af710e35af78343bc7f1 (diff) | |
parent | 466d002a4b5d2ccbb621ba580288787b88275255 (diff) |
Merge pull request #11999 from vespa-engine/hmusum/add-access-log-by-default-for-application-container-cluster
Add access log by default for application container cluster
Diffstat (limited to 'config-model')
-rw-r--r-- | config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java | 2 | ||||
-rw-r--r-- | config-model/src/test/java/com/yahoo/vespa/model/container/xml/AccessLogTest.java | 12 |
2 files changed, 3 insertions, 11 deletions
diff --git a/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java b/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java index aef2697a5dd..d09f23da64e 100644 --- a/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java +++ b/config-model/src/main/java/com/yahoo/vespa/model/container/xml/ContainerModelBuilder.java @@ -302,7 +302,7 @@ public class ContainerModelBuilder extends ConfigModelBuilder<ContainerModel> { AccessLogBuilder.buildIfNotDisabled(deployState, cluster, accessLog).ifPresent(cluster::addComponent); } - if (accessLogElements.isEmpty() && cluster.getSearch() != null) + if (accessLogElements.isEmpty()) cluster.addDefaultSearchAccessLog(); } diff --git a/config-model/src/test/java/com/yahoo/vespa/model/container/xml/AccessLogTest.java b/config-model/src/test/java/com/yahoo/vespa/model/container/xml/AccessLogTest.java index 4ea10c9a1c1..00ab175f496 100644 --- a/config-model/src/test/java/com/yahoo/vespa/model/container/xml/AccessLogTest.java +++ b/config-model/src/test/java/com/yahoo/vespa/model/container/xml/AccessLogTest.java @@ -18,30 +18,22 @@ import static org.junit.Assert.assertEquals; /** * @author gjoranv - * @since 5.5 */ public class AccessLogTest extends ContainerModelBuilderTestBase { @Test - public void default_access_log_is_only_added_when_search_is_present() { + public void default_access_log_is_added_by_default() { Element cluster1Elem = DomBuilderTest.parse( "<container id='cluster1' version='1.0'>", - "<search />", - nodesXml, - "</container>"); - Element cluster2Elem = DomBuilderTest.parse( - "<container id='cluster2' version='1.0'>", " <nodes>", " <node hostalias='mockhost' baseport='1234' />", " </nodes>", "</container>" ); - createModel(root, cluster1Elem, cluster2Elem); + createModel(root, cluster1Elem); assertNotNull(getJsonAccessLog("cluster1")); - assertNull( getJsonAccessLog("cluster2")); assertNull(getVespaAccessLog("cluster1")); - assertNull(getVespaAccessLog("cluster2")); } @Test |