Fix BinaryUnit not checking if the input matches the expected pattern

1 files changed, 3 insertions, 1 deletions

diff --git a/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/BinaryUnit.java b/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/BinaryUnit.java
index d953d072087..b30f44bfdb1 100644
--- a/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/BinaryUnit.java
+++ b/config-model/src/main/java/com/yahoo/vespa/model/builder/xml/dom/BinaryUnit.java
@@ -16,7 +16,9 @@ public class BinaryUnit {
     public static double valueOf(String valueString) {
         Matcher matcher = pattern.matcher(valueString);
 
-        matcher.matches();
+        if (!matcher.matches()) {
+            throw new IllegalArgumentException("Value '" + valueString + "' does not match the pattern for binary unit");
+        }
         double value = Double.valueOf(matcher.group(1));
         String unit = matcher.group(3);
         if (unit != null) {